Merge pull request #299 from fferegrino/drop-3.8

Drop Python 3.8

Author: lyz-code

.github/workflows/build.yml

@@ -12,15 +12,15 @@ jobs:
     name: Build and publish Python distributions to TestPyPI
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@master
+      - uses: actions/checkout@v4
       - uses: pdm-project/setup-pdm@main
         name: Setup Python and PDM
         with:
-          python-version: 3.9
+          python-version: 3.11
       - name: Build package
         run: make build-package
       - name: Publish distribution to Test PyPI
-        uses: pypa/gh-action-pypi-publish@master
+        uses: pypa/gh-action-pypi-publish@release/v1
         with:
           password: ${{ secrets.test_pypi_password }}
           repository_url: https://test.pypi.org/legacy/
@@ -29,15 +29,15 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
         with:
           # Number of commits to fetch. 0 indicates all history.
           # Default: 1
           fetch-depth: 0
       - uses: pdm-project/setup-pdm@main
         name: Setup Python and PDM
         with:
-          python-version: 3.9
+          python-version: 3.11
       - name: Install dependencies
         run: make install
       - name: Build the Documentation

.github/workflows/install.yml

@@ -11,11 +11,11 @@ jobs:
     strategy:
       max-parallel: 3
       matrix:
-        python-version: [3.8, 3.9, '3.10', '3.11']
+        python-version: [3.9, '3.10', '3.11']
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v4
       - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v1
+        uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python-version }}
       - name: Install the program

.github/workflows/tests.yml

@@ -14,11 +14,11 @@ jobs:
     strategy:
       max-parallel: 4
       matrix:
-        python-version: [3.8, 3.9, '3.10', '3.11']
+        python-version: [3.9, '3.10', '3.11']
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v4
       - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v1
+        uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python-version }}
       - name: Install program

.github/workflows/update.yml

@@ -9,14 +9,14 @@ jobs:
   Update:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@master
+      - uses: actions/checkout@v4
         with:
           persist-credentials: false
           fetch-depth: 0
       - name: Set up Python
-        uses: actions/setup-python@v1
+        uses: actions/setup-python@v5
         with:
-          python-version: 3.9
+          python-version: 3.11
       - name: Install program
         run: |
           # All these steps are required so that mypy behaves equally than the

.safety-policy.yml

@@ -10,6 +10,9 @@ security: # configuration for the `safety check` command
         # We recommend making use of the optional `reason` and `expires` keys for each vulnerability that you ignore.
         70612: # Example vulnerability ID
             reason: we don't use jinja2 from_string
+        76170:
+            reason: Temporary ignore while upgrading Python versions and dropping 3.8 support
+            expires: '2025-10-31'
     continue-on-vulnerability-error: False # Suppress non-zero exit codes when vulnerabilities are found. Enable this in pipelines and CI/CD processes if you want to pass builds that have vulnerabilities. We recommend you set this to False.
 alert: # configuration for the `safety alert` command
     security:

mkdocs.yml

@@ -13,7 +13,7 @@ plugins:
   - mkdocstrings:
       handlers:
         python:
-          rendering:
+          options:
             show_root_heading: true
             heading_level: 1
   - autolinks

pdm.lock

@@ -42,7 +42,6 @@ classifiers=[
     "Operating System :: POSIX",
     "Programming Language :: Python",
     "Programming Language :: Python :: 3",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
@@ -270,6 +269,7 @@ pylint = [
   "-W1201", # Use lazy % formatting in logging functions. Deprecated rule in favor of
             # f-strings.
   "-C0301", # Lines too long. Already covered by E501.
+  "-R0917", # Too many positional arguments
 ]
 mccabe = ["+*"]
 pep8-naming = ["+*"]
@@ -288,6 +288,12 @@ pyflakes = [
 ]
 
 [tool.flakeheaven.exceptions."tests/"]
+flake8-aaa = [
+  "-AAA01 ", # no Act block found in test
+  "-AAA03", # expected 1 blank line before Act block, found none
+  "-AAA04", # expected 1 blank line before Assert block, found none
+  "-AAA05", # blank line in block
+]
 flake8-docstrings = [
   "-D205", # 1 blank line required between summary line and description
   "-D212", # Multi-line docstring summary should start at the first line
@@ -296,17 +302,25 @@ flake8-docstrings = [
 ]
 flake8-annotations = [
   "-ANN001",
+  "-ANN201", # Missing return type annotation for public function
   "-ANN401", # Dynamically typed expressions (typing.Any) are disallowed
 ]
+flake8-pytest-style = [
+  "-PT023", # use @pytest.mark.secondary over @pytest.mark.secondary(
+]
 pylint = [
   "-R0201", # Method could be a function. Raised because the methods of a test class
             # don't use the self object, which is not wrong.
   "-W0613", # Unused argument in function, but in tests there are fixtures that even
             # though they are not used in the function directly, they are used to
             # configure the test.
+  "-W0621", # Redefining name 'xyz' from outer scope
   "-R0904", # Too many public methods (25/20) (too-many-public-methods)
   "-C0302", # Allows module to have unlimited number of lines.
 ]
+pycodestyle = [
+  "-E501", # line too long
+]
 
 [tool.flakeheaven.exceptions."tests/factories.py"]
 pylint = [

pyproject.toml

@@ -7,12 +7,12 @@
 from typing import Dict, List, Optional, Tuple
 
 import click
-from _io import TextIOWrapper
 
 from yamlfix import services, version
 from yamlfix.config import configure_yamlfix
 from yamlfix.entrypoints import load_logger
 from yamlfix.model import YamlfixConfig
+from yamlfix.services import Files
 
 log = logging.getLogger(__name__)
 
@@ -90,11 +90,11 @@ def cli(  # pylint: disable=too-many-arguments
 
     Use - to read from stdin. No other files can be specified in this case.
     """
-    files_to_fix: List[TextIOWrapper] = []
+    files_to_fix: Files = []
     if "-" in files:
         if len(files) > 1:
             raise ValueError("Cannot specify '-' and other files at the same time.")
-        files_to_fix = [sys.stdin]
+        files_to_fix = (sys.stdin,)  # type: ignore[assignment]
     else:
         paths = [Path(file) for file in files]
         real_files = []