Nits

Author: Nukem9

source/maindll/FFFrameInterpolator.h

@@ -1,6 +1,5 @@
 #pragma once
 
-#include <FidelityFX/host/ffx_interface.h>
 #include <FidelityFX/host/ffx_opticalflow.h>
 #include "FFDilator.h"
 #include "FFInterfaceWrapper.h"

source/maindll/FFFrameInterpolatorVK.cpp

@@ -194,18 +194,16 @@ bool FFFrameInterpolatorVK::LoadTextureFromNGXParameters(
 	FfxResource *OutFfxResource,
 	FfxResourceStates State)
 {
-	void *resource = nullptr;
-	NGXParameters->GetVoidPointer(Name, &resource);
+	NGXVulkanResourceHandle *resourceHandle = nullptr;
+	NGXParameters->GetVoidPointer(Name, reinterpret_cast<void **>(&resourceHandle));
 
-	if (!resource)
+	if (!resourceHandle)
 	{
 		*OutFfxResource = {};
 		return false;
 	}
 
 	// Vulkan provides no mechanism to query resource information. Convert it manually.
-	auto resourceHandle = static_cast<const NGXVulkanResourceHandle *>(resource);
-
 	if (resourceHandle->Type != 0)
 		__debugbreak();
 

source/maindll/NGX/NvNGXDirectX12.cpp

@@ -74,7 +74,7 @@ NGXDLLEXPORT NGXResult NVSDK_NGX_D3D12_EvaluateFeature(ID3D12GraphicsCommandList
 		auto itr = FeatureInstanceHandles.find(InstanceHandle->InternalId);
 
 		if (itr == FeatureInstanceHandles.end())
-			return decltype(itr->second){};
+			return decltype(itr->second) {};
 
 		return itr->second;
 	}();

source/maindll/Util.cpp

@@ -1,6 +1,5 @@
 #include <spdlog/sinks/basic_file_sink.h>
 #include <Windows.h>
-#include <stdio.h>
 #include "Util.h"
 
 namespace Util

source/maindll/dllmain.cpp

@@ -48,7 +48,7 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpvReserved)
 			BUILD_VERSION_MINOR);
 		spdlog::warn("implementation of AMD's FSR 3.");
 		spdlog::warn("");
-		spdlog::warn("dlssg-to-fsr3 is freely downloadable from https://www.nexusmods.com/site/mods/738?tab=files or "
+		spdlog::warn("dlssg-to-fsr3 is freely downloadable from https://www.nexusmods.com/site/mods/738 or "
 					 "https://github.com/Nukem9/dlssg-to-fsr3/releases.");
 		spdlog::warn("If you paid for these files, you've been scammed.");
 		spdlog::warn("");

source/wrapper_generic/dllmain.cpp

@@ -6,7 +6,7 @@
 // sl.common.dll      loads  _nvngx.dll       <- we are here
 // _nvngx.dll         loads  nvngx_dlssg.dll  <- intercept this stage
 //
-std::vector<const wchar_t *> TargetLibrariesToHook = { L"sl.interposer.dll", L"sl.common.dll", L"sl.dlss_g.dll", L"_nvngx.dll" };
+std::vector TargetLibrariesToHook = { L"sl.interposer.dll", L"sl.common.dll", L"sl.dlss_g.dll", L"_nvngx.dll" };
 constinit const wchar_t *TargetImplementationDll = L"nvngx_dlssg.dll";
 constinit const wchar_t *RelplacementImplementationDll = L"dlssg_to_fsr3_amd_is_better.dll";
 
@@ -114,9 +114,8 @@ bool PatchImportsForModule(const wchar_t *Path, HMODULE ModuleHandle)
 	if (!Path || !ModuleHandle)
 		return false;
 
-	const bool isMatch = std::any_of(
-		TargetLibrariesToHook.begin(),
-		TargetLibrariesToHook.end(),
+	const bool isMatch = std::ranges::any_of(
+		TargetLibrariesToHook,
 		[path = std::wstring_view(Path)](const wchar_t *Target)
 		{
 			return path.ends_with(Target);
@@ -159,7 +158,7 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpvReserved)
 			// "Returnal\         Returnal\     Binaries\Win64\Returnal-Win64-Shipping.exe"
 			// "Hogwarts Legacy\  Phoenix\      Binaries\Win64\HogwartsLegacy.exe"
 			// "SW Jedi Survivor\ SwGame\       Binaries\Win64\JediSurvivor.exe"
-			// "Atomic Heart\     AtomicHeart\  Binaries\Win64\AtomicHeart-Win64-Shipping.exe
+			// "Atomic Heart\     AtomicHeart\  Binaries\Win64\AtomicHeart-Win64-Shipping.exe"
 			// "MMS\              MidnightSuns\ Binaries\Win64\MidnightSuns-Win64-Shipping.exe"
 			//
 			// "Dying Light 2\    ph\work\bin\x64\sl.interposer.dll"
@@ -177,10 +176,9 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpvReserved)
 
 			if (!LoadLibraryW(bruteInterposerPaths[0]))
 			{
-				wchar_t path[2048];
-
 				for (auto interposer : bruteInterposerPaths)
 				{
+					wchar_t path[2048];
 					if (!Util::GetModulePath(path, true, GetModuleHandleW(nullptr)))
 						break;
 
@@ -193,9 +191,8 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpvReserved)
 		}
 
 		// We probably loaded after sl.interposer.dll and sl.common.dll. Try patching them up front.
-		bool anyPatched = std::count_if(
-			TargetLibrariesToHook.begin(),
-			TargetLibrariesToHook.end(),
+		bool anyPatched = std::ranges::count_if(
+			TargetLibrariesToHook,
 			[](const wchar_t *Target)
 		{
 			return PatchImportsForModule(Target, GetModuleHandleW(Target)) && _wcsicmp(Target, TargetEGSServicesDll) != 0;

source/wrapper_generic/nvapi.cpp

@@ -33,7 +33,7 @@ struct NV_SCG_PRIORITY_INFO
 	uint32_t Unknown8; // 14
 };
 
-struct NV_D3DKMT_PRIVATE_DRIVER_DATA // nvwg2umx.dll (546.33)
+struct NV_D3DKMT_PRIVATE_DRIVER_DATA // nvwgf2umx.dll (546.33)
 {
 	uint32_t Header;				 // 0 NVDA
 	char Padding[0xE4];				 // 4