Improve debugger automation script

Author: Nukem9

.gitignore

@@ -4,6 +4,7 @@
 
 # Launch.vs.json isn't user-specific in this repo
 !.vs/launch.vs.json
+!.vs/launch_with_automation.ps1
 
 # Artifacts
 bin/*

.vs/launch.vs.json

@@ -12,16 +12,12 @@
       "currentDir": "${env.GAME_ROOT_DIRECTORY}",
       "exe": "${env.ComSpec}",
       "args": [
-        "/C \"${env.GAME_ROOT_DIRECTORY}/Cyberpunk2077.exe\" && taskkill /F /IM VsDebugConsole.exe"
+        "/C \"powershell.exe -WindowStyle Hidden -nologo -ExecutionPolicy Bypass -File ^\"${workspaceRoot}/.vs/launch_with_automation.ps1^\" Launch\""
       ],
       "environment": [
         {
-          "name": "VS_DEBUGGER_REQUEST",
-          "value": "${env.VS_DEBUGGER_REQUEST}"
-        },
-        {
-          "name": "VS_DEBUGGER_PROC",
-          "value": "${env.VS_DEBUGGER_PROC}"
+          "name": "GAME_DEBUGGER_CMDLINE",
+          "value": "${env.GAME_DEBUGGER_CMDLINE}"
         }
       ]
     }

.vs/launch_with_automation.ps1

@@ -0,0 +1,122 @@
+param ($Action, $VSProcessId, $ChildProcessId)
+
+# See end of file
+
+Add-Type -Language Csharp -TypeDefinition @"
+using System;
+using System.Runtime.InteropServices;
+using System.Runtime.InteropServices.ComTypes;
+
+namespace VSAutomationHelper
+{
+    public class Main
+    {
+        [DllImport("ole32.dll")]
+        private static extern int CreateBindCtx(uint reserved, out IBindCtx ppbc);
+
+        public static object FindDTEInstanceByProcessId(int processId)
+        {
+            IBindCtx bindContext = null;
+            IRunningObjectTable objectTable = null;
+            IEnumMoniker enumMonikers = null;
+     
+            try
+            {
+                Marshal.ThrowExceptionForHR(CreateBindCtx(0, out bindContext));
+                bindContext.GetRunningObjectTable(out objectTable);
+                objectTable.EnumRunning(out enumMonikers);
+
+                IMoniker[] moniker = new IMoniker[1];
+                IntPtr numberFetched = IntPtr.Zero;
+
+                while (enumMonikers.Next(1, moniker, numberFetched) == 0)
+                {
+                    var runningObjectMoniker = moniker[0];
+
+                    if (runningObjectMoniker == null)
+                        continue;
+
+                    try
+                    {
+                        string name = null;
+                        runningObjectMoniker.GetDisplayName(bindContext, null, out name);
+
+                        if (name.StartsWith("!VisualStudio.DTE.")) // Consistent from 2010~2022
+                        {
+                            int idIndex = name.IndexOf(':');
+
+                            if (idIndex != -1 && int.Parse(name.Substring(idIndex + 1)) == processId)
+                            {
+                                object runningObject = null;
+                                Marshal.ThrowExceptionForHR(objectTable.GetObject(runningObjectMoniker, out runningObject));
+
+                                return runningObject;
+                            }
+                        }
+                    }
+                    catch (UnauthorizedAccessException)
+                    {
+                        // Inaccessible due to permissions
+                    }
+                }
+            }
+            finally
+            {
+                if (enumMonikers != null)
+                    Marshal.ReleaseComObject(enumMonikers);
+     
+                if (objectTable != null)
+                    Marshal.ReleaseComObject(objectTable);
+     
+                if (bindContext != null)
+                    Marshal.ReleaseComObject(bindContext);
+            }
+
+            return null;
+        }
+    }
+}
+"@
+
+#
+# .\script.ps1 Launch     Callback from Visual Studio to launch the game
+# .\script.ps1 Attach     Callback from the game to attach Visual Studio's debugger
+#
+# GAME_DEBUGGER_CMDLINE   Env var holding a command line expression that launches the game
+# GAME_DEBUGGER_REQUEST   Env var holding a command line expression that runs when the game is ready for debugger attach
+# GAME_DEBUGGER_PROC      Env var holding kernel32.dll's CreateProcessA import function string to prevent AV false positives
+#
+if ($Action -eq 'Launch') {
+    # Visual Studio doesn't necessarily launch the debugee. Keep chasing the parent PID until we find it.
+    $parentVSProcessId = $PID
+
+    while ($true) {
+        $wmiProcess = Get-WmiObject Win32_Process -Filter ProcessId=$parentVSProcessId
+
+        if ($wmiProcess.ProcessName.ToLower() -eq "devenv.exe") {
+            break;
+        }
+
+        $parentVSProcessId = $wmiProcess.ParentProcessId
+    }
+
+    # Start process with special environment vars set
+    $localPSPath = (Get-Process -Id $PID | Get-Item).FullName
+    $localScriptPath = $MyInvocation.MyCommand.Path
+
+    $env:GAME_DEBUGGER_REQUEST = '"' + $localPSPath + '" -ExecutionPolicy Bypass -File "' + $localScriptPath + '" Attach ' + $parentVSProcessId + ' '
+    $env:GAME_DEBUGGER_PROC = 'kernel32!CreateProcessA'
+
+    & $env:GAME_DEBUGGER_CMDLINE
+}
+elseif ($Action -eq 'Attach') {
+    # Callback from game DLL side. Tell Visual Studio to attach to its process.
+    $automationDTE = [VSAutomationHelper.Main]::FindDTEInstanceByProcessId($VSProcessId)
+
+    foreach ($process in $automationDTE.Debugger.LocalProcesses) {
+        if ($process.ProcessID -eq $ChildProcessId) {
+            $process.Attach()
+            break;
+        }
+    }
+}

CMakeUserEnvVars.json

@@ -5,9 +5,8 @@
       "name": "config-envvars",
       "hidden": true,
       "environment": {
-        "___GAME_ROOT_DIRECTORY": "C:/Program Files (x86)/Steam/steamapps/common/Cyberpunk 2077/bin/x64",
-        "VS_DEBUGGER_REQUEST": "vsjitdebugger.exe -p ",
-        "VS_DEBUGGER_PROC": "kernel32!CreateProcessA"
+        "___GAME_ROOT_DIRECTORY": "C:/Program Files (x86)/Steam/steamapps/common/Horizon Forbidden West Complete Edition",
+        "GAME_DEBUGGER_CMDLINE": "$env{GAME_ROOT_DIRECTORY}/HorizonForbiddenWest.exe"
       }
     }
   ]

source/wrapper_dt/dllmain.cpp

@@ -5,20 +5,23 @@ BOOL WINAPI RawDllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpvReserved)
 {
 	if (fdwReason == DLL_PROCESS_ATTACH)
 	{
-		// Start vsjitdebugger.exe if a debugger isn't already attached. VS_DEBUGGER_REQUEST determines the
-		// command line and VS_DEBUGGER_PROC is used to hide the CreateProcessA IAT entry.
-		if (char cmd[256] = {}, proc[256] = {}; !IsDebuggerPresent() &&
-												GetEnvironmentVariableA("VS_DEBUGGER_REQUEST", cmd, ARRAYSIZE(cmd)) > 0 &&
-												GetEnvironmentVariableA("VS_DEBUGGER_PROC", proc, ARRAYSIZE(proc)) > 0)
+		// Start vsjitdebugger.exe if a debugger isn't already attached. GAME_DEBUGGER_REQUEST determines the
+		// command line and GAME_DEBUGGER_PROC is used to hide the CreateProcessA IAT entry.
+		if (char cmd[512] = {}, proc[512] = {}; !IsDebuggerPresent() &&
+												GetEnvironmentVariableA("GAME_DEBUGGER_REQUEST", cmd, ARRAYSIZE(cmd)) > 0 &&
+												GetEnvironmentVariableA("GAME_DEBUGGER_PROC", proc, ARRAYSIZE(proc)) > 0)
 		{
 			std::to_chars(cmd + strlen(cmd), std::end(cmd), GetCurrentProcessId());
 			auto moduleName = proc;
 			auto importName = strchr(proc, '!') + 1;
 			importName[-1] = '\0';
 
 			PROCESS_INFORMATION pi = {};
+
 			STARTUPINFOA si = {};
 			si.cb = sizeof(si);
+			si.dwFlags = STARTF_USESHOWWINDOW;
+			si.wShowWindow = SW_HIDE;
 
 			auto c = reinterpret_cast<decltype(&CreateProcessA)>(GetProcAddress(GetModuleHandleA(moduleName), importName));
 			c(nullptr, cmd, nullptr, nullptr, false, 0, nullptr, nullptr, &si, &pi);