update default memory store and add tests

Author: lzztt

Makefile

@@ -17,7 +17,6 @@ test-cov:
 		./node_modules/.bin/_mocha --require build/helper.js --bail \
 		build/test
 
-
 test-travis:
 	rm -rf build coverage && \
 		babel --plugins='external-helpers' src -d build -s && \

src/memory_store.js

@@ -12,11 +12,19 @@ module.exports = class MemoryStore {
     this.sessions[sid] = val
 
     if (sid in this.timeouts) clearTimeout(this.timeouts[sid])
-    this.timeouts[sid] = setTimeout(this.destroy.bind(this, sid), ttl)
+
+    this.timeouts[sid] = setTimeout(() => {
+      delete this.sessions[sid]
+      delete this.timeouts[sid]
+    }, ttl)
   }
 
   destroy(sid) {
-    delete this.sessions[sid]
-    delete this.timeouts[sid]
+    if (sid in this.timeouts) {
+      delete this.sessions[sid]
+
+      clearTimeout(this.timeouts[sid])
+      delete this.timeouts[sid]
+    }
   }
 }

test/memory_store.test.js

@@ -0,0 +1,86 @@
+const MemoryStore = require('../src/memory_store')
+const expect = require('chai').expect
+
+describe('default memory store', () => {
+  let sid
+  let data
+  let ttl
+
+  beforeEach(() => {
+    sid = Math.random().toString()
+    data = {
+      number: Math.random(),
+    }
+    ttl = Math.floor(Math.random() * 300) + 300
+  })
+
+  it('can set a session with ttl', () => {
+    const store = new MemoryStore()
+    store.set(sid, data, ttl)
+  })
+
+  it('will get "undefined" for a non-exist session', () => {
+    const store = new MemoryStore()
+    expect(store.get(sid)).to.be.equal(undefined)
+  })
+
+  it('can destory a session', () => {
+    const store = new MemoryStore()
+    store.destroy(sid)
+  })
+
+  it('can get session data within ttl', (done) => {
+    const store = new MemoryStore()
+    store.set(sid, data, ttl)
+    setTimeout(() => {
+      expect(store.get(sid)).to.be.deep.equal(data)
+      done()
+    }, ttl - 100)
+  })
+
+  it('cannot get session data after ttl', (done) => {
+    const store = new MemoryStore()
+    store.set(sid, data, ttl)
+    setTimeout(() => {
+      expect(store.get(sid)).to.be.equal(undefined)
+      done()
+    }, ttl + 100)
+  })
+
+  it('cannot get session data after destory within ttl', (done) => {
+    const store = new MemoryStore()
+    store.set(sid, data, ttl)
+    store.destroy(sid)
+    setTimeout(() => {
+      expect(store.get(sid)).to.be.equal(undefined)
+      done()
+    }, ttl - 100)
+  })
+
+  it('can reset session data and update ttl', (done) => {
+    const store = new MemoryStore()
+    const newData = {
+      number: Math.random(),
+    }
+    const resetTime = ttl - 200
+
+    store.set(sid, data, ttl)
+
+    setTimeout(() => {
+      store.set(sid, newData, ttl)
+    }, resetTime)
+
+    setTimeout(() => {
+      expect(store.get(sid)).to.be.deep.equal(data)
+    }, resetTime - 100)
+
+    setTimeout(() => {
+      expect(store.get(sid)).to.be.deep.equal(newData)
+    }, (resetTime + ttl) - 100)
+
+    setTimeout(() => {
+      expect(store.get(sid)).to.be.equal(undefined)
+      done()
+    }, (resetTime + ttl) + 100)
+  })
+})