fix: validate scaledui multiplier on initialize

Author: Oighty

programs/earn/src/instructions/admin/initialize.rs

@@ -17,7 +17,7 @@ use spl_token_2022::extension::{
 
 // local dependencies
 use crate::{
-    constants::{ANCHOR_DISCRIMINATOR_SIZE, PORTAL_PROGRAM},
+    constants::{ANCHOR_DISCRIMINATOR_SIZE, PORTAL_PROGRAM, INDEX_SCALE_F64},
     errors::EarnError,
     state::{EarnGlobal, GLOBAL_SEED, TOKEN_AUTHORITY_SEED},
     utils::{conversion::update_multiplier, token::thaw_token_account},
@@ -27,7 +27,6 @@ cfg_if::cfg_if!(
     if #[cfg(feature = "migrate")] {
         declare_program!(old_earn);
         use old_earn::{accounts::Global as OldGlobal, ID as OLD_EARN_PROGRAM_ID};
-
         use crate::utils::conversion::{get_scaled_ui_config, principal_to_amount_up};
     }
 );
@@ -59,7 +58,7 @@ pub struct Initialize<'info> {
 
     #[account(
         mut,
-        mint::token_program = token_program
+        mint::token_program = token_program,
         mint::decimals = 6, // Must be 6 decimals
     )]
     pub m_mint: InterfaceAccount<'info, Mint>,
@@ -113,7 +112,7 @@ pub struct Initialize<'info> {
 }
 
 impl Initialize<'_> {
-    fn validate(&self) -> Result<()> {
+    fn validate(&self, _current_index: u64) -> Result<()> {
         // Get the mint account data once and reuse it
         let account_info = self.m_mint.to_account_info();
         let mint_data = account_info.try_borrow_data()?;
@@ -133,6 +132,23 @@ impl Initialize<'_> {
             return err!(EarnError::InvalidMint);
         }
 
+        // Verify that the new multiplier is less than or equal to the current index (if migrating) or provided index (if not migrating)
+        // This is required because the call to our update_multiplier fn will fail silently if the multiplier on the mint is greater.
+        // That behavior is desired except when initializing the program. Therefore, we catch the error here.
+        let current_multiplier: f64;
+        let mint_multiplier: f64 = scaled_ui_config.new_multiplier.into();
+        cfg_if! {
+            if #[cfg(feature = "migrate")] {
+                current_multiplier = self.old_global_account.index as f64 / INDEX_SCALE_F64;
+
+            } else {
+                current_multiplier = _current_index as f64 / INDEX_SCALE_F64;
+            }
+        }
+        if mint_multiplier > current_multiplier {
+            return err!(EarnError::InvalidMint);
+        }
+
         // 2. Must have the Default Account State extension
         // and the global account as the freeze authority
         if !extensions.contains(&ExtensionType::DefaultAccountState) {
@@ -168,7 +184,7 @@ impl Initialize<'_> {
         Ok(())
     }
 
-    #[access_control(ctx.accounts.validate())]
+    #[access_control(ctx.accounts.validate(_current_index))]
     pub fn handler(ctx: Context<Initialize>, _current_index: u64) -> Result<()> {
         // Set global state
         ctx.accounts.global_account.set_inner(EarnGlobal {

tests/unit/portal.test.ts

@@ -279,7 +279,7 @@ describe('Portal unit tests', () => {
     });
     test('initialize earn', async () => {
       await earn.methods
-        .initialize(new BN(100_000_000))
+        .initialize(new BN(1e12))
         .accounts({
           admin: admin.publicKey,
           mMint: mint.publicKey,