Skip to content

Commit 2acadf0

Browse files
m0dBm0dB
authored andcommitted
fix 14326 but now correctly: no need to keep the pointer as a member
1 parent ec635a4 commit 2acadf0

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

src/controllers/legacycontrollersettings.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -160,10 +160,8 @@ QWidget* LegacyControllerBooleanSetting::buildInputWidget(QWidget* pParent) {
160160
pLabelWidget->setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Maximum);
161161
pLabelWidget->setText(label());
162162
pLabelWidget->setBuddy(pCheckBox);
163-
if (!m_pToggleCheckboxEventFilter) {
164-
m_pToggleCheckboxEventFilter = make_parented<ToggleCheckboxEventFilter>(this);
165-
}
166-
pLabelWidget->installEventFilter(m_pToggleCheckboxEventFilter.get());
163+
auto pToggleCheckboxEventFilter = make_parented<ToggleCheckboxEventFilter>(pLabelWidget);
164+
pLabelWidget->installEventFilter(pToggleCheckboxEventFilter.get());
167165

168166
QBoxLayout* pLayout = new QHBoxLayout();
169167

src/controllers/legacycontrollersettings.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,6 @@ class LegacyControllerBooleanSetting
194194
bool eventFilter(QObject* pObj, QEvent* pEvent) override;
195195
};
196196

197-
parented_ptr<ToggleCheckboxEventFilter> m_pToggleCheckboxEventFilter;
198197
bool m_savedValue;
199198
bool m_defaultValue;
200199
bool m_editedValue;

0 commit comments

Comments
 (0)