fix: Connection pooling logic and limit check calculations

Previously, when the m3u-proxy API was slow or timed out (which happens when under heavy load), the reconciliation would:

- Get empty results ([])
- Think there were 0 active streams
- Reset all profile connection counts to 0
- Allow unlimited new connections
- Overwhelm the provider with too many connections
- Cause editor to be blocked

Now:
- If API fails → returns null instead of []
- Reconciliation skips that playlist when it gets null
- Connection counts stay accurate
- Provider limits are respected

No more blocking!

Author: sparkison

app/Console/Commands/ReconcileProfileConnections.php

@@ -68,6 +68,20 @@ protected function reconcilePlaylist(Playlist $playlist, M3uProxyService $proxyS
         // Get active streams from m3u-proxy for this playlist
         $activeStreams = M3uProxyService::getPlaylistActiveStreams($playlist);
 
+        // CRITICAL: If API call failed (returned null), skip reconciliation
+        // This prevents incorrectly zeroing out connection counts on timeout
+        if ($activeStreams === null) {
+            $this->error('    Failed to fetch streams from m3u-proxy - SKIPPING reconciliation for this playlist');
+            $this->warn('    This prevents incorrectly resetting connection counts to zero');
+
+            return;
+        }
+
+        // If we got an empty array, that's valid - there are legitimately no streams
+        if (empty($activeStreams)) {
+            $this->info('    No active streams found - will reset profile counts to 0');
+        }
+
         // Build a map of profile_id => active stream count
         $profileStreamCounts = [];
 

app/Services/M3uProxyService.php

@@ -159,7 +159,7 @@ public static function getPlaylistActiveStreamsCount($playlist): int
 
         try {
             $endpoint = $service->apiBaseUrl.'/streams/by-metadata';
-            $response = Http::timeout(3)->acceptJson()
+            $response = Http::timeout(10)->acceptJson()
                 ->withHeaders($service->apiToken ? [
                     'X-API-Token' => $service->apiToken,
                 ] : [])
@@ -187,41 +187,69 @@ public static function getPlaylistActiveStreamsCount($playlist): int
 
     /**
      * Get active streams for a specific playlist using metadata filtering
+     * Returns null on failure to distinguish from legitimately empty results
      */
-    public static function getPlaylistActiveStreams($playlist): array
+    public static function getPlaylistActiveStreams($playlist, int $retries = 2): ?array
     {
         $service = new self;
 
         if (empty($service->apiBaseUrl)) {
-            return [];
+            Log::warning('Cannot fetch playlist streams: m3u-proxy API URL not configured');
+
+            return null;
         }
 
-        try {
-            $endpoint = $service->apiBaseUrl.'/streams/by-metadata';
-            $response = Http::timeout(3)->acceptJson()
-                ->withHeaders($service->apiToken ? [
-                    'X-API-Token' => $service->apiToken,
-                ] : [])
-                ->get($endpoint, [
-                    'field' => 'playlist_uuid',
-                    'value' => $playlist->uuid,
-                    'active_only' => true,
-                ]);
+        $endpoint = $service->apiBaseUrl.'/streams/by-metadata';
+        $attempt = 0;
 
-            if ($response->successful()) {
-                $data = $response->json();
+        while ($attempt < $retries) {
+            try {
+                $response = Http::timeout(10)->acceptJson()
+                    ->withHeaders($service->apiToken ? [
+                        'X-API-Token' => $service->apiToken,
+                    ] : [])
+                    ->get($endpoint, [
+                        'field' => 'playlist_uuid',
+                        'value' => $playlist->uuid,
+                        'active_only' => true,
+                    ]);
 
-                return $data['matching_streams'] ?? [];
-            }
+                if ($response->successful()) {
+                    $data = $response->json();
 
-            Log::warning('Failed to fetch playlist streams from m3u-proxy: HTTP '.$response->status());
+                    return $data['matching_streams'] ?? [];
+                }
 
-            return [];
-        } catch (Exception $e) {
-            Log::warning('Failed to fetch playlist streams from m3u-proxy: '.$e->getMessage());
+                Log::warning('Failed to fetch playlist streams from m3u-proxy: HTTP '.$response->status(), [
+                    'attempt' => $attempt + 1,
+                    'max_attempts' => $retries,
+                ]);
+
+                $attempt++;
+                if ($attempt < $retries) {
+                    sleep(1); // Wait 1 second before retry
+                }
 
-            return [];
+            } catch (Exception $e) {
+                Log::warning('Failed to fetch playlist streams from m3u-proxy: '.$e->getMessage(), [
+                    'attempt' => $attempt + 1,
+                    'max_attempts' => $retries,
+                ]);
+
+                $attempt++;
+                if ($attempt < $retries) {
+                    sleep(1); // Wait 1 second before retry
+                }
+            }
         }
+
+        // All retries failed
+        Log::error('All attempts to fetch playlist streams from m3u-proxy failed', [
+            'playlist_uuid' => $playlist->uuid,
+            'attempts' => $retries,
+        ]);
+
+        return null;
     }
 
     /**
@@ -237,7 +265,7 @@ public static function isChannelActive(Channel $channel): bool
 
         try {
             $endpoint = $service->apiBaseUrl.'/streams/by-metadata';
-            $response = Http::timeout(2)->acceptJson()
+            $response = Http::timeout(10)->acceptJson()
                 ->withHeaders($service->apiToken ? [
                     'X-API-Token' => $service->apiToken,
                 ] : [])
@@ -283,7 +311,7 @@ public static function getActiveStreamsCountByMetadata(string $field, string $va
 
         try {
             $endpoint = $service->apiBaseUrl.'/streams/by-metadata';
-            $response = Http::timeout(3)->acceptJson()
+            $response = Http::timeout(10)->acceptJson()
                 ->withHeaders($service->apiToken ? [
                     'X-API-Token' => $service->apiToken,
                 ] : [])

routes/console.php

@@ -54,7 +54,7 @@
 
 // Reconcile profile connection counts
 Schedule::command('profiles:reconcile')
-    ->everyMinute()
+    ->everyFiveMinutes()
     ->withoutOverlapping();
 
 // Refresh provider profile info (every 15 minutes)