test(seq,seqe): NotNil

Author: m4gshm

seq/test/api_test.go

@@ -793,6 +793,17 @@ func Test_ConvertNilSafe(t *testing.T) {
 	assert.Equal(t, expected, s)
 }
 
+func Test_NotLit(t *testing.T) {
+	var (
+		first  = "first"
+		third  = "third"
+		fifth  = "fifth"
+		source = seq.Of(&first, nil, &third, nil, &fifth)
+		result = seq.NotNil(source)
+	)
+	assert.Equal(t, slice.Of(&first, &third, &fifth), result.Slice())
+}
+
 func Test_ConvertOK(t *testing.T) {
 	s := seq.Of(1, 3, 4, 5, 7, 8, 9, 11)
 	converter := func(i int) (string, bool) { return strconv.Itoa(i), even(i) }

seqe/api.go

@@ -426,7 +426,7 @@ func Group[S ~SeqE[T], T any, K comparable, V any](seq S, keyExtractor func(T) K
 }
 
 // NotNil returns teh seq without nil elements.
-func NotNil[T any](seq SeqE[*T]) SeqE[*T] {
+func NotNil[T any](seq SeqE[*T]) seq.SeqE[*T] {
 	return Filter(seq, not.Nil[T])
 }
 

seqe/test/api_test.go

@@ -828,6 +828,19 @@ func Test_ConvertNilSafe(t *testing.T) {
 	assert.Equal(t, expected, s)
 }
 
+func Test_NotLit(t *testing.T) {
+	var (
+		first  = "first"
+		third  = "third"
+		fifth  = "fifth"
+		source = seq.ToSeq2(seq.Of(&first, nil, &third, nil, &fifth), noErr)
+		result = seqe.NotNil(source)
+	)
+	s, err := result.Slice()
+	assert.Equal(t, slice.Of(&first, &third, &fifth), s)
+	assert.NoError(t, err)
+}
+
 func Test_ConvertOK(t *testing.T) {
 	s := seq.ToSeq2(seq.Of(1, 3, 4, 5, 7, 8, 9, 11), noErr)
 	converter := func(i int) (string, bool) { return strconv.Itoa(i), even(i) }

slice/test/api_test.go

@@ -298,9 +298,9 @@ func Test_ConvertNotNil(t *testing.T) {
 func Test_ConvertValues(t *testing.T) {
 	type entity struct{ val string }
 	var (
-		source   = []*entity{{"first"}, nil, {"third"}, nil, {"fifth"}}
+		source   = []*entity{{"first"}, nil, {"third"}, {}, {"fifth"}}
 		result   = convert.NotNil(source, as.Val[entity])
-		expected = []entity{{"first"}, {"third"}, {"fifth"}}
+		expected = []entity{{"first"}, {"third"}, {}, {"fifth"}}
 	)
 	assert.Equal(t, expected, result)
 }