Skip to content

Commit 2c5dcc1

Browse files
committed
Fix missing return value and uninitialized variables
1 parent 05e4b95 commit 2c5dcc1

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

src/LoRaWan.cpp

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@ bool LoRaWanClass::setDataRate(_data_rate_t dataRate, _physical_type_t physicalT
167167
loraDebugPrint(DEFAULT_DEBUGTIME);
168168
#endif
169169
delay(DEFAULT_TIMEWAIT);
170+
return true;
170171
}
171172

172173
void LoRaWanClass::setPower(short power)
@@ -430,8 +431,8 @@ short LoRaWanClass::receivePacket(char *buffer, short length, short *rssi)
430431
ptr += 5;
431432
for(short i = 0; ; i ++)
432433
{
433-
char temp[2] = {0};
434-
unsigned char tmp, result = 0;
434+
char temp[2] = {0, 0};
435+
unsigned char tmp = '?', result = 0;
435436

436437
temp[0] = *(ptr + i * 3);
437438
temp[1] = *(ptr + i * 3 + 1);
@@ -473,7 +474,7 @@ short LoRaWanClass::receivePacket(char *buffer, short length, short *rssi)
473474
for(short i = 0; ; i ++)
474475
{
475476
char temp[2] = {0};
476-
unsigned char tmp, result = 0;
477+
unsigned char tmp = '?', result = 0;
477478

478479
temp[0] = *(ptr + i * 3);
479480
temp[1] = *(ptr + i * 3 + 1);
@@ -858,7 +859,7 @@ short LoRaWanClass::receivePacketP2PMode(unsigned char *buffer, short length, sh
858859
for(short i = 0; i < number; i ++)
859860
{
860861
char temp[2] = {0};
861-
unsigned char tmp, result = 0;
862+
unsigned char tmp='?', result = 0;
862863

863864
temp[0] = *(ptr + i * 2);
864865
temp[1] = *(ptr + i * 2 + 1);
@@ -985,7 +986,7 @@ short LoRaWanClass::readLine(char *buffer, short length, unsigned char timeout)
985986
{
986987
short i = 0;
987988
unsigned long timerStart, timerEnd;
988-
char c;
989+
char c='\n';
989990

990991
timerStart = millis();
991992

0 commit comments

Comments
 (0)