Skip to content

Commit 1328dd2

Browse files
committed
SpreadsheetFormatterSharedExpression was ExpressionSpreadsheetFormatter extends SpreadsheetFormatterShared
1 parent 2e5b4b0 commit 1328dd2

File tree

3 files changed

+20
-20
lines changed

3 files changed

+20
-20
lines changed

src/main/java/walkingkooka/spreadsheet/format/ExpressionSpreadsheetFormatter.java renamed to src/main/java/walkingkooka/spreadsheet/format/SpreadsheetFormatterSharedExpression.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,16 +31,16 @@
3131
* A {@link SpreadsheetFormatter} that executes the given {@link Expression} and returning a {@link TextNode}
3232
* from the result.
3333
*/
34-
final class ExpressionSpreadsheetFormatter implements SpreadsheetFormatter,
35-
TreePrintable {
34+
final class SpreadsheetFormatterSharedExpression extends SpreadsheetFormatterShared
35+
implements TreePrintable {
3636

37-
static ExpressionSpreadsheetFormatter with(final Expression expression) {
38-
return new ExpressionSpreadsheetFormatter(
37+
static SpreadsheetFormatterSharedExpression with(final Expression expression) {
38+
return new SpreadsheetFormatterSharedExpression(
3939
Objects.requireNonNull(expression, "expression")
4040
);
4141
}
4242

43-
private ExpressionSpreadsheetFormatter(final Expression expression) {
43+
private SpreadsheetFormatterSharedExpression(final Expression expression) {
4444
super();
4545
this.expression = expression;
4646
}
@@ -76,10 +76,10 @@ public int hashCode() {
7676

7777
@Override
7878
public boolean equals(final Object other) {
79-
return this == other || other instanceof ExpressionSpreadsheetFormatter && this.equals0((ExpressionSpreadsheetFormatter) other);
79+
return this == other || other instanceof SpreadsheetFormatterSharedExpression && this.equals0((SpreadsheetFormatterSharedExpression) other);
8080
}
8181

82-
private boolean equals0(final ExpressionSpreadsheetFormatter other) {
82+
private boolean equals0(final SpreadsheetFormatterSharedExpression other) {
8383
return this.expression.equals(other.expression);
8484
}
8585

src/main/java/walkingkooka/spreadsheet/format/SpreadsheetFormatters.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,10 +136,10 @@ public static SpreadsheetFormatter empty() {
136136
}
137137

138138
/**
139-
* {@see ExpressionSpreadsheetFormatter}
139+
* {@see SpreadsheetFormatterSharedExpression}
140140
*/
141141
public static SpreadsheetFormatter expression(final Expression expression) {
142-
return ExpressionSpreadsheetFormatter.with(expression);
142+
return SpreadsheetFormatterSharedExpression.with(expression);
143143
}
144144

145145
/**

src/test/java/walkingkooka/spreadsheet/format/ExpressionSpreadsheetFormatterTest.java renamed to src/test/java/walkingkooka/spreadsheet/format/SpreadsheetFormatterSharedExpressionTest.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@
8686
import java.util.Locale;
8787
import java.util.Optional;
8888

89-
public final class ExpressionSpreadsheetFormatterTest implements SpreadsheetFormatterTesting2<ExpressionSpreadsheetFormatter>,
90-
HashCodeEqualsDefinedTesting2<ExpressionSpreadsheetFormatter>,
89+
public final class SpreadsheetFormatterSharedExpressionTest extends SpreadsheetFormatterSharedTestCase<SpreadsheetFormatterSharedExpression>
90+
implements HashCodeEqualsDefinedTesting2<SpreadsheetFormatterSharedExpression>,
9191
SpreadsheetMetadataTesting {
9292

9393
private final static ExpressionNumberKind EXPRESSION_NUMBER_KIND = ExpressionNumberKind.BIG_DECIMAL;
@@ -129,10 +129,10 @@ public void testToken() {
129129
private final static ExpressionFunctionName HELLO = SpreadsheetExpressionFunctions.name("hello");
130130

131131
@Override
132-
public ExpressionSpreadsheetFormatter createFormatter() {
132+
public SpreadsheetFormatterSharedExpression createFormatter() {
133133

134134
// 1 + hello($FORMAT_VALUE)
135-
return ExpressionSpreadsheetFormatter.with(
135+
return SpreadsheetFormatterSharedExpression.with(
136136
Expression.add(
137137
Expression.value(EXPRESSION_NUMBER_KIND.one()),
138138
Expression.call(
@@ -367,15 +367,15 @@ public CaseSensitivity expressionFunctionNameCaseSensitivity() {
367367
@Test
368368
public void testEqualsDifferentExpression() {
369369
this.checkNotEquals(
370-
ExpressionSpreadsheetFormatter.with(
370+
SpreadsheetFormatterSharedExpression.with(
371371
Expression.value("Different2")
372372
)
373373
);
374374
}
375375

376376
@Override
377-
public ExpressionSpreadsheetFormatter createObject() {
378-
return ExpressionSpreadsheetFormatter.with(
377+
public SpreadsheetFormatterSharedExpression createObject() {
378+
return SpreadsheetFormatterSharedExpression.with(
379379
Expression.value("Hello1")
380380
);
381381
}
@@ -385,13 +385,13 @@ public ExpressionSpreadsheetFormatter createObject() {
385385
@Test
386386
public void testTreePrintable() {
387387
this.treePrintAndCheck(
388-
ExpressionSpreadsheetFormatter.with(
388+
SpreadsheetFormatterSharedExpression.with(
389389
Expression.add(
390390
Expression.value(1),
391391
Expression.value(23)
392392
)
393393
),
394-
"ExpressionSpreadsheetFormatter\n" +
394+
"SpreadsheetFormatterSharedExpression\n" +
395395
" AddExpression\n" +
396396
" ValueExpression 1 (java.lang.Integer)\n" +
397397
" ValueExpression 23 (java.lang.Integer)\n"
@@ -401,7 +401,7 @@ public void testTreePrintable() {
401401
// class............................................................................................................
402402

403403
@Override
404-
public Class<ExpressionSpreadsheetFormatter> type() {
405-
return ExpressionSpreadsheetFormatter.class;
404+
public Class<SpreadsheetFormatterSharedExpression> type() {
405+
return SpreadsheetFormatterSharedExpression.class;
406406
}
407407
}

0 commit comments

Comments
 (0)