Skip to content

Commit eb6ccb1

Browse files
authored
Merge pull request #8624 from mP1/feature/SpreadsheetStorageSpreadsheetCell-file-extension-stripped
SpreadsheetStorageSpreadsheetCell: file extension stripped
2 parents 144edc3 + 14de690 commit eb6ccb1

File tree

2 files changed

+36
-1
lines changed

2 files changed

+36
-1
lines changed

src/main/java/walkingkooka/spreadsheet/storage/SpreadsheetStorageSpreadsheetCell.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ List<StorageValueInfo> listNonNull(final StoragePath path,
177177

178178
private static SpreadsheetExpressionReference parseExpressionReference(final StorageName name) {
179179
return SpreadsheetSelection.parseExpressionReference(
180-
name.value()
180+
name.withoutFileExtension()
181181
);
182182
}
183183

src/test/java/walkingkooka/spreadsheet/storage/SpreadsheetStorageSpreadsheetCellTest.java

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,41 @@ public void testLoadCell() {
163163
);
164164
}
165165

166+
@Test
167+
public void testLoadCellWithFileExtension() {
168+
final SpreadsheetContext spreadsheetContext = this.createSpreadsheetContext();
169+
170+
final SpreadsheetCell cell = SpreadsheetSelection.A1.setFormula(
171+
SpreadsheetFormula.EMPTY.setText("=1")
172+
);
173+
174+
SpreadsheetEngines.basic()
175+
.saveCell(
176+
cell,
177+
spreadsheetContext.spreadsheetEngineContext()
178+
);
179+
180+
final SpreadsheetStorageContext storageContext = this.createContext(spreadsheetContext);
181+
182+
final StoragePath path = StoragePath.parse("/A1.json");
183+
184+
this.loadAndCheck(
185+
this.createStorage(),
186+
path,
187+
storageContext,
188+
StorageValue.with(
189+
path,
190+
Optional.of(
191+
SpreadsheetCellSet.EMPTY.concat(
192+
spreadsheetContext.storeRepository()
193+
.cells()
194+
.loadOrFail(cell.reference())
195+
)
196+
)
197+
).setContentType(SpreadsheetMediaTypes.MEMORY_CELL)
198+
);
199+
}
200+
166201
@Test
167202
public void testLoadCellRange() {
168203
final SpreadsheetContext spreadsheetContext = this.createSpreadsheetContext();

0 commit comments

Comments
 (0)