Skip to content

Commit 019db02

Browse files
authored
fix: separate out push and pull jobs (#7)
1 parent 013e7e4 commit 019db02

File tree

5 files changed

+21
-10
lines changed

5 files changed

+21
-10
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44
3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/stable/.github/workflows/pr-branch-check-name.yml
55

66
## Summary
7-
{provide a thorough description of the changes}
7+
- {provide a thorough description of the changes}
88

99
## Testing Plan
10-
{explain how this has been tested, and what additional testing should be done}
10+
- {explain how this has been tested, and what additional testing should be done}
1111

1212
## Master Issue
13-
Closes https://go.mparticle.com/work/REPLACEME
13+
- Closes https://go.mparticle.com/work/REPLACEME

.github/workflows/pull-request.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
name: "Pull Request"
1+
name: "Pull Request Checks"
22

3-
on: [ push, pull_request, workflow_dispatch ]
3+
on: [ pull_request ]
44

55
jobs:
66

.github/workflows/push.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
name: "Push Checks"
2+
3+
on: [ push, workflow_dispatch ]
4+
5+
jobs:
6+
7+
higgs-shop-sample-app:
8+
name: "Check Higgs Shop Sample App"
9+
uses: mParticle/mparticle-workflows/.github/workflows/android-sample-app-push.yml@stable
10+
with:
11+
app_relative_path: "core-sdk-samples/higgs-shop-sample-app"
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1-
name: Reusable Workflows
1+
name: "Reusable Workflows"
22

33
on:
44
pull_request:
55

66
jobs:
77
pr-branch-check-name:
8-
name: Check PR for semantic branch name
8+
name: "Check PR for semantic branch name"
99
uses: mParticle/mparticle-workflows/.github/workflows/pr-branch-check-name.yml@stable
1010
pr-title-check:
11-
name: Check PR for semantic title
11+
name: "Check PR for semantic title"
1212
uses: mParticle/mparticle-workflows/.github/workflows/pr-title-check.yml@stable
1313
pr-branch-target-gitflow:
14-
name: Check PR for semantic target branch
14+
name: "Check PR for semantic target branch"
1515
uses: mParticle/mparticle-workflows/.github/workflows/pr-branch-target-gitflow.yml@stable

core-sdk-samples/higgs-shop-sample-app/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ The purpose of the app is to highlight the following features:
1414

1515
1. Open this repository in Android Studio after cloning
1616

17-
2. Update the `HIGGS_SHOP_SAMPLE_APP_KEY` and `HIGGS_SHOP_SAMPLE_APP_SECRET` variable with your mParticle Android API Key inside app/build.gradle.kts file
17+
2. Update the `HIGGS_SHOP_SAMPLE_APP_KEY` & `HIGGS_SHOP_SAMPLE_APP_SECRET` variable with your mParticle Android API Key inside app/build.gradle.kts file
1818

1919
- Visit your [mParticle Workspace](https://app.mparticle.com/setup/inputs/apps) to generate API Credentials
2020

0 commit comments

Comments
 (0)