Skip to content

Commit e1ba42d

Browse files
MPKitConfigurationTest fix
1 parent 066f11f commit e1ba42d

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

UnitTests/ObjCTests/MPKitConfigurationTests.mm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ - (void)tearDown {
8181

8282
- (void)testInstance {
8383
XCTAssertNotNil(kitConfiguration);
84-
XCTAssertEqualObjects(kitConfiguration.configurationHash, @(762651950));
84+
XCTAssertEqualObjects(kitConfiguration.configurationHash, @(969680750));
8585
XCTAssertEqualObjects(kitConfiguration.integrationId, @37);
8686
XCTAssertEqualObjects(kitConfiguration.attributeValueFilteringHashedAttribute, @"12345");
8787
XCTAssertEqualObjects(kitConfiguration.attributeValueFilteringHashedValue, @"54321");
@@ -183,7 +183,7 @@ - (void)testInvalidConfiguration {
183183

184184
kitConfig = [[MPKitConfiguration alloc] initWithDictionary:configuration];
185185
XCTAssertNotNil(kitConfig);
186-
XCTAssertEqualObjects(kitConfig.configurationHash, @(1495473349));
186+
XCTAssertEqualObjects(kitConfig.configurationHash, @(-1872513399));
187187
XCTAssertEqualObjects(kitConfig.integrationId, @80);
188188

189189
XCTAssertNil(kitConfig.filters);

mParticle-Apple-SDK/Kits/MPKitConfiguration.mm

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,11 @@ - (instancetype)initWithDictionary:(NSDictionary *)configurationDictionary {
2323
return nil;
2424
}
2525

26-
NSData *ekConfigData = [NSJSONSerialization dataWithJSONObject:configurationDictionary options:0 error:nil];
26+
NSJSONWritingOptions options = 0;
27+
if (@available(iOS 11.0, tvOS 11.0, *)) {
28+
options = NSJSONWritingSortedKeys;
29+
}
30+
NSData *ekConfigData = [NSJSONSerialization dataWithJSONObject:configurationDictionary options:options error:nil];
2731
NSString *ekConfigString = [[NSString alloc] initWithData:ekConfigData encoding:NSUTF8StringEncoding];
2832
_configurationHash = @([[MPIHasher hashString:ekConfigString] intValue]);
2933

@@ -114,16 +118,11 @@ - (id)initWithCoder:(NSCoder *)coder {
114118
@try {
115119
configurationDictionary = [coder decodeObjectOfClass:[NSDictionary class] forKey:@"configurationDictionary"];
116120
}
117-
118121
@catch ( NSException *e) {
119122
configurationDictionary = nil;
120123
MPILogError(@"Exception decoding MPKitConfiguration Attributes: %@", [e reason]);
121124
}
122125

123-
@finally {
124-
self = [self initWithDictionary:configurationDictionary];
125-
}
126-
127126
self = [self initWithDictionary:configurationDictionary];
128127
if (!self) {
129128
return nil;

0 commit comments

Comments
 (0)