Skip to content

Commit f9a267a

Browse files
chore: fix stub removal TODO — media SDK stays on v1.x versioning
mParticle-Apple-Media-SDK is not moving to v9.0; it will be its own release (e.g. 1.8.0) that bumps its mParticle-Apple-SDK dependency from ~> 8.37 to ~> 9.0. Update TODO comments to reflect that the stubs should be removed once that next release lands on CocoaPods CDN. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent b559b97 commit f9a267a

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

kits/adobe/adobe-5/Sources/MediaSDKStub/MPMediaTypes.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
// the AdobeMedia subspec against the local mParticle-Apple-SDK 9.0.0 without
44
// fetching the real CDN release (which requires mParticle-Apple-SDK ~> 8.37).
55
// TODO: Remove this file (and MPMediaTypes.m + mParticle-Apple-Media-SDK.podspec at repo root)
6-
// once the mParticle-Apple-Media-SDK v9.0 PR is merged and released to CocoaPods CDN.
6+
// once the next mParticle-Apple-Media-SDK release (with mParticle-Apple-SDK ~> 9.0 dependency)
7+
// is published to CocoaPods CDN.
78

89
#import <Foundation/Foundation.h>
910

mParticle-Apple-Media-SDK.podspec

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,9 @@
44
# pod lib lint. The CDN version (1.x) depends on mParticle-Apple-SDK ~> 8.37, which conflicts
55
# with the local SDK bumped to 9.0.0 for CI. This stub provides a minimal ObjC header that
66
# defines MPMediaEvent and related types so that MPKitAdobeMedia.m compiles cleanly.
7-
# TODO: Remove this stub (and kits/adobe/adobe-5/Sources/MediaSDKStub/) once the
8-
# mParticle-Apple-Media-SDK v9.0 PR is merged and a new release is published to CocoaPods CDN.
9-
# At that point the CDN version will depend on mParticle-Apple-SDK ~> 9.0 and all
10-
# dependencies resolve without local overrides.
7+
# TODO: Remove this stub (and kits/adobe/adobe-5/Sources/MediaSDKStub/) once the next
8+
# mParticle-Apple-Media-SDK release (with its mParticle-Apple-SDK dependency updated to ~> 9.0)
9+
# is published to CocoaPods CDN. At that point all dependencies resolve without local overrides.
1110
Pod::Spec.new do |s|
1211
s.name = "mParticle-Apple-Media-SDK"
1312
s.version = "9.0.0"

0 commit comments

Comments
 (0)