Address PR Comments

Author: alexs-mparticle

src/cookieSyncManager.interfaces.ts

@@ -2,6 +2,7 @@ import { MPID } from '@mparticle/web-sdk';
 import { Dictionary } from './utils';
 import { IConsentRules } from './consent';
 
+export type CookieSyncDates = Dictionary<number>; 
 export interface ICookieSyncManager {
     attemptCookieSync: (
         previousMPID: MPID,
@@ -12,7 +13,7 @@ export interface ICookieSyncManager {
         url: string,
         moduleId: string,
         mpid: MPID,
-        cookieSyncDates: Dictionary<number>,
+        cookieSyncDates: CookieSyncDates,
         filteringConsentRuleValues: IConsentRules,
         mpidIsNotInCookies: boolean,
         requiresConsent: boolean

src/cookieSyncManager.ts

@@ -1,8 +1,8 @@
 import { isEmpty, replaceAmpWithAmpersand, replaceMPID } from './utils';
 import Constants from './constants';
-import { ICookieSyncManager } from './cookieSyncManager.interfaces';
+import { CookieSyncDates, ICookieSyncManager } from './cookieSyncManager.interfaces';
 import { MParticleWebSDK } from './sdkRuntimeModels';
-import { Dictionary, MPID } from '@mparticle/web-sdk';
+import { MPID } from '@mparticle/web-sdk';
 import { IConsentRules } from './consent';
 
 const { Messages } = Constants;
@@ -143,7 +143,7 @@ export default function CookieSyncManager(
         url: string,
         moduleId: string,
         mpid: MPID,
-        cookieSyncDates: Dictionary<number>,
+        cookieSyncDates: CookieSyncDates,
         filteringConsentRuleValues: IConsentRules,
         mpidIsNotInCookies: boolean,
         requiresConsent: boolean

src/persistence.interfaces.ts

@@ -14,6 +14,7 @@ import {
 import { Dictionary } from './utils';
 import { IMinifiedConsentJSONObject } from './consent';
 import { UserAttributes } from './identity-user-interfaces';
+import { CookieSyncDates } from './cookieSyncManager.interfaces';
 
 export type UploadsTable = Dictionary<any>;
 export interface iForwardingStatsBatches {
@@ -79,10 +80,8 @@ export interface IPersistenceMinified extends Dictionary {
     // };
 }
 
-export type CookieSyncDate = Dictionary<number>;
-
 export interface IUserPersistenceMinified extends Dictionary {
-    csd: CookieSyncDate; // Cookie Sync Dates // list of timestamps for last cookie sync
+    csd: CookieSyncDates; // Cookie Sync Dates // list of timestamps for last cookie sync
     con: IMinifiedConsentJSONObject; // Consent State
     ui: UserIdentities; // User Identities
     ua: UserAttributes; // User Attributes
@@ -121,7 +120,7 @@ export interface IPersistence {
     getDomain(doc: string, locationHostname: string): string;
     getCartProducts(mpid: MPID): Product[];
     setCartProducts(allProducts: Product[]): void;
-    saveUserCookieSyncDatesToPersistence(mpid: MPID, csd: CookieSyncDate): void;
+    saveUserCookieSyncDatesToPersistence(mpid: MPID, csd: CookieSyncDates): void;
     savePersistence(persistance: IPersistenceMinified): void;
     getPersistence(): IPersistenceMinified;
     getFirstSeenTime(mpid: MPID): string | null;

src/store.ts

@@ -37,6 +37,7 @@ import {
     IGlobalStoreV2MinifiedKeys,
     IPersistenceMinified,
 } from './persistence.interfaces';
+import { CookieSyncDates } from './cookieSyncManager.interfaces';
 
 // This represents the runtime configuration of the SDK AFTER
 // initialization has been complete and all settings and
@@ -168,7 +169,7 @@ export interface IStore {
     identifyCalled: boolean;
     isLoggedIn: boolean;
     sideloadedKitsCount?: number;
-    cookieSyncDates: Dictionary<number>;
+    cookieSyncDates: CookieSyncDates;
     integrationAttributes: IntegrationAttributes;
     requireDelay: boolean;
     isLocalStorageAvailable: boolean | null;

test/jest/cookieSyncManager.spec.ts

@@ -440,7 +440,7 @@ describe.only('CookieSyncManager', () => {
             expect(loggerSpy).toHaveBeenCalledWith('Performing cookie sync');
         });
 
-        it.only('should return early if the user has not consented to the cookie sync', () => {
+        it('should return early if the user has not consented to the cookie sync', () => {
             const mockImage = {
                 onload: jest.fn(),
                 src: '',
@@ -494,7 +494,7 @@ describe.only('CookieSyncManager', () => {
             expect(cookieSyncDates[42]).toBeUndefined();
         });
 
-        it.only('should return early if requiresConsent and mpidIsNotInCookies are both true', () => {
+        it('should return early if requiresConsent and mpidIsNotInCookies are both true', () => {
             const mockImage = {
                 onload: jest.fn(),
                 src: '',