Skip to content

Commit 1c39967

Browse files
committed
move from mpinstance to store, use workspace token instead of apikey
1 parent 35fb7bd commit 1c39967

File tree

5 files changed

+8
-10
lines changed

5 files changed

+8
-10
lines changed

src/mp-instance.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ import Identity from './identity';
3535
import Consent, { IConsent } from './consent';
3636
import KitBlocker from './kitBlocking';
3737
import ConfigAPIClient from './configAPIClient';
38-
import ForegroundTimer from './foregroundTimeTracker';
3938
import IdentityAPIClient from './identityApiClient';
4039
import { isFunction, valueof } from './utils';
4140
import { LocalStorageVault } from './vault';
@@ -67,7 +66,6 @@ export type IntegrationDelays = Dictionary<boolean>;
6766
// https://go.mparticle.com/work/SQDSDKS-6949
6867
export interface IMParticleWebSDKInstance extends MParticleWebSDK {
6968
// Private Properties
70-
_timeOnSiteTimer: ForegroundTimer;
7169
_APIClient: IAPIClient;
7270
_Consent: IConsent;
7371
_CookieSyncManager: ICookieSyncManager;
@@ -151,7 +149,6 @@ export default function mParticleInstance(this: IMParticleWebSDKInstance, instan
151149
}
152150
}
153151
this.init = function(apiKey, config) {
154-
self._timeOnSiteTimer = new ForegroundTimer(apiKey);
155152
if (!config) {
156153
console.warn(
157154
'You did not pass a config object to init(). mParticle will not initialize properly'

src/serverModel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,7 @@ export default function ServerModel(
345345
event.data,
346346
event.name
347347
),
348-
ActiveTimeOnSite: mpInstance._timeOnSiteTimer?.getTimeInForeground(),
348+
ActiveTimeOnSite: mpInstance._Store.timeOnSiteTimer?.getTimeInForeground(),
349349
SourceMessageId:
350350
event.sourceMessageId ||
351351
mpInstance._Helpers.generateUniqueId(),

src/sessionManager.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ export default function SessionManager(
132132
});
133133

134134
mpInstance._Store.nullifySession();
135-
mpInstance._timeOnSiteTimer.resetTimer();
135+
mpInstance._Store.timeOnSiteTimer.resetTimer();
136136
return;
137137
}
138138

@@ -144,7 +144,7 @@ export default function SessionManager(
144144
mpInstance.Logger.verbose(
145145
Messages.InformationMessages.AbandonEndSession
146146
);
147-
mpInstance._timeOnSiteTimer.resetTimer();
147+
mpInstance._Store.timeOnSiteTimer.resetTimer();
148148

149149
return;
150150
}
@@ -158,7 +158,7 @@ export default function SessionManager(
158158
mpInstance.Logger.verbose(
159159
Messages.InformationMessages.NoSessionToEnd
160160
);
161-
mpInstance._timeOnSiteTimer.resetTimer();
161+
mpInstance._Store.timeOnSiteTimer.resetTimer();
162162

163163
return;
164164
}
@@ -186,7 +186,7 @@ export default function SessionManager(
186186
}
187187
}
188188

189-
mpInstance._timeOnSiteTimer.resetTimer();
189+
mpInstance._Store.timeOnSiteTimer.resetTimer();
190190
};
191191

192192
this.setSessionTimer = function(): void {

src/store.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ import {
3838
} from './persistence.interfaces';
3939
import { CookieSyncDates, IPixelConfiguration } from './cookieSyncManager';
4040
import { IMParticleWebSDKInstance } from './mp-instance';
41+
import ForegroundTimer from './foregroundTimeTracker';
4142

4243
// This represents the runtime configuration of the SDK AFTER
4344
// initialization has been complete and all settings and
@@ -165,6 +166,7 @@ export interface IStore {
165166
configurationLoaded: boolean;
166167
identityCallInFlight: boolean;
167168
SDKConfig: Partial<SDKConfig>;
169+
timeOnSiteTimer: ForegroundTimer;
168170
nonCurrentUserMPIDs: Record<MPID, Dictionary>;
169171
identifyCalled: boolean;
170172
isLoggedIn: boolean;
@@ -680,6 +682,7 @@ export default function Store(
680682

681683
if (workspaceToken) {
682684
this.SDKConfig.workspaceToken = workspaceToken;
685+
mpInstance._Store.timeOnSiteTimer = new ForegroundTimer(workspaceToken);
683686
} else {
684687
mpInstance.Logger.warning(
685688
'You should have a workspaceToken on your config object for security purposes.'

test/src/tests-core-sdk.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1511,7 +1511,5 @@ describe('core SDK', function() {
15111511

15121512
done();
15131513
});
1514-
1515-
15161514
});
15171515
});

0 commit comments

Comments
 (0)