Skip to content

Commit 46eb534

Browse files
Address PR Comments
1 parent 096f338 commit 46eb534

File tree

2 files changed

+4
-14
lines changed

2 files changed

+4
-14
lines changed

src/configAPIClient.ts

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import {
1313
FetchUploader,
1414
XHRUploader,
1515
} from './uploaders';
16+
import { IPixelConfiguration } from './cookieSyncManager.interfaces';
1617

1718
export interface IKitConfigs extends IKitFilterSettings {
1819
name: string;
@@ -65,17 +66,6 @@ export interface IConsentRuleValue {
6566
hasConsented: boolean;
6667
}
6768

68-
export interface IPixelConfig {
69-
name: string;
70-
moduleId: number;
71-
esId: number;
72-
isDebug: boolean;
73-
isProduction: boolean;
74-
settings: Dictionary;
75-
frequencyCap: number;
76-
pixelUrl: string;
77-
redirectUrl: string;
78-
}
7969

8070
export interface IConfigResponse {
8171
appName: string;
@@ -85,7 +75,7 @@ export interface IConfigResponse {
8575
secureServiceUrl: string;
8676
minWebviewBridgeVersion: number;
8777
workspaceToken: string;
88-
pixelConfigs: IPixelConfig[];
78+
pixelConfigs: IPixelConfiguration[];
8979
flags: SDKEventCustomFlags;
9080
}
9181

src/cookieSyncManager.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { isEmpty, replaceAmpWithAmpersand, replaceMPID } from './utils';
22
import Constants from './constants';
3-
import { CookieSyncDates, ICookieSyncManager } from './cookieSyncManager.interfaces';
3+
import { CookieSyncDates, ICookieSyncManager, IPixelConfiguration } from './cookieSyncManager.interfaces';
44
import { MParticleWebSDK } from './sdkRuntimeModels';
55
import { MPID } from '@mparticle/web-sdk';
66
import { IConsentRules } from './consent';
@@ -39,7 +39,7 @@ export default function CookieSyncManager(
3939
const { pixelConfigurations } = mpInstance._Store;
4040
const persistence = mpInstance._Persistence.getPersistence();
4141

42-
pixelConfigurations.forEach(pixelSettings => {
42+
pixelConfigurations.forEach((pixelSettings: IPixelConfiguration) => {
4343
// set requiresConsent to false to start each additional pixel configuration
4444
// set to true only if filteringConsenRuleValues.values.length exists
4545
let requiresConsent = false;

0 commit comments

Comments
 (0)