Skip to content

Commit 619debb

Browse files
Apply suggestions from code review
Co-authored-by: Robert Ing <[email protected]>
1 parent ac7b53b commit 619debb

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/cookieSyncManager.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { Dictionary, MPID } from '@mparticle/web-sdk';
77
import { IConsentRules } from './consent';
88

99
const { Messages } = Constants;
10-
const {InformationMessages} = Messages;
10+
const { InformationMessages } = Messages;
1111

1212
export default function CookieSyncManager(this: ICookieSyncManager, mpInstance: MParticleWebSDK) {
1313
const self = this;
@@ -72,7 +72,6 @@ export default function CookieSyncManager(this: ICookieSyncManager, mpInstance:
7272
// outside of the loop
7373
var persistence = mpInstance._Persistence.getPersistence();
7474

75-
7675
// TODO: Is there a historic reason for checking for previousMPID?
7776
// it does not appear to be passed in anywhere
7877
if (previousMPID && previousMPID !== mpid) {

test/jest/cookieSyncManager.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ describe('CookieSyncManager', () => {
204204
);
205205
});
206206

207-
it('should perform a cookie sync if lastSyncDateForModule is past the frequency cap', () => {
207+
it('should perform a cookie sync if lastSyncDateForModule is passed the frequency cap', () => {
208208
const now = new Date().getTime();
209209

210210
// Rev the date by one

0 commit comments

Comments
 (0)