refactor: Migrate mParticle Instance Manager to TypeScript

Author: alexs-mparticle

src/mparticle-instance-manager.js src/mparticle-instance-manager.tssrc/mparticle-instance-manager.js renamed to src/mparticle-instance-manager.ts

@@ -1,9 +1,13 @@
 import Polyfill from './polyfill';
-import Types from './types';
+import Types, { CommerceEventType, EventType, ProductActionType, PromotionActionType } from './types';
 import Constants from './constants';
-import mParticleInstance from './mp-instance.js';
+import mParticleInstance, { IMParticleWebSDKInstance } from './mp-instance.js';
 import _BatchValidator from './mockBatchCreator';
 import MPSideloadedKit from './sideloadedKit';
+import { IMParticleInstanceManager } from './sdkRuntimeModels';
+import { IStore } from './store';
+import { Dictionary } from '@mparticle/web-sdk';
+import { valueof } from './utils';
 
 if (!Array.prototype.forEach) {
     Array.prototype.forEach = Polyfill.forEach;
@@ -17,21 +21,27 @@ if (!Array.prototype.filter) {
     Array.prototype.filter = Polyfill.filter;
 }
 
+// https://go.mparticle.com/work/SQDSDKS-6768
 if (!Array.isArray) {
+    // @ts-ignore
     Array.prototype.isArray = Polyfill.isArray;
 }
 
-function mParticle() {
+
+// Question: Should we just change this to mParticleInsanceManager?
+export default function mParticle(this: IMParticleInstanceManager, instanceName?: string) {
     var self = this;
     // Only leaving this here in case any clients are trying to access mParticle.Store, to prevent from throwing
-    this.Store = {};
-    this._instances = {};
+    this.Store = {} as IStore;
+    this._instances = {} as Dictionary<IMParticleWebSDKInstance>;
     this.IdentityType = Types.IdentityType;
-    this.EventType = Types.EventType;
-    this.CommerceEventType = Types.CommerceEventType;
-    this.PromotionType = Types.PromotionActionType;
-    this.ProductActionType = Types.ProductActionType;
-    this.MPSideloadedKit = MPSideloadedKit;
+    this.EventType = EventType as unknown as valueof<typeof EventType>;
+    this.CommerceEventType = CommerceEventType as unknown as valueof<typeof CommerceEventType>;
+    this.PromotionType = PromotionActionType as unknown as valueof<typeof PromotionActionType>;
+    this.ProductActionType = ProductActionType as unknown as valueof<typeof ProductActionType>;
+
+    // QUESTION:  Should this be a 'new' instance?
+    this.MPSideloadedKit =  MPSideloadedKit as unknown as valueof<typeof MPSideloadedKit>;
 
     if (typeof window !== 'undefined') {
         this.isIOS =
@@ -67,7 +77,10 @@ function mParticle() {
         ).toLowerCase();
         var client = self._instances[instanceName];
         if (client === undefined) {
-            client = new mParticleInstance(apiKey, config, instanceName);
+
+            // FIXME: This is not an accurate signature for the constructor
+            // client = new mParticleInstance(apiKey, config, instanceName);
+            client = new mParticleInstance(instanceName);
             self._instances[instanceName] = client;
         }
 
@@ -480,11 +493,12 @@ function mParticle() {
     };
 }
 
-var mparticleInstance = new mParticle();
+// Can we get rid of this and just rename the class to mparticleInstanceManager?
+const mparticleInstance = new mParticle();
 
 if (typeof window !== 'undefined') {
     window.mParticle = mparticleInstance;
-    window.mParticle._BatchValidator = new _BatchValidator();
-}
 
-export default mparticleInstance;
+    // https://go.mparticle.com/work/SQDSDKS-5053
+    window.mParticle._BatchValidator = new _BatchValidator();
+}