Migrate Identity API Client to TypeScript

Author: alexs-mparticle

src/identityApiClient.interfaces.ts

@@ -1,6 +1,7 @@
 import { IdentityApiData, MPID, UserIdentities } from '@mparticle/web-sdk';
 import {
     IdentityCallback,
+    IdentityResultBody,
     IIdentityResponse,
 } from './identity-user-interfaces';
 import {
@@ -29,9 +30,9 @@ export interface IIdentityApiClient {
     getUploadUrl: (method: IdentityAPIMethod, mpid: MPID) => string;
     getIdentityResponseFromFetch: (
         response: Response,
-        responseBody: string
+        responseBody: IdentityResultBody
     ) => IIdentityResponse;
-    getIdentityResponseFromXHR: (response: Response) => IIdentityResponse;
+    getIdentityResponseFromXHR: (response: XMLHttpRequest) => IIdentityResponse;
 }
 
 // https://go.mparticle.com/work/SQDSDKS-6568

src/identityApiClient.js src/identityApiClient.tssrc/identityApiClient.js renamed to src/identityApiClient.ts

@@ -3,13 +3,14 @@ import { sendAliasRequest } from './aliasRequestApiClient';
 import { FetchUploader, XHRUploader } from './uploaders';
 import { CACHE_HEADER } from './identity-utils';
 import { parseNumber } from './utils';
+import { IIdentityApiClient } from './identityApiClient.interfaces';
 
 var HTTPCodes = Constants.HTTPCodes,
     Messages = Constants.Messages;
 
 const { Modify } = Constants.IdentityMethods;
 
-export default function IdentityAPIClient(mpInstance) {
+export default function IdentityAPIClient(this: IIdentityApiClient, mpInstance) {
     this.sendAliasRequest = async function(aliasRequest, callback) {
         await sendAliasRequest(mpInstance, aliasRequest, callback);
     };
@@ -74,7 +75,7 @@ export default function IdentityAPIClient(mpInstance) {
                     responseBody
                 );
             } else {
-                identityResponse = this.getIdentityResponseFromXHR(response);
+                identityResponse = this.getIdentityResponseFromXHR(response as unknown as XMLHttpRequest);
             }
 
             verbose(

test/jest/identityApiClient.spec.ts

@@ -0,0 +1,26 @@
+import IdentityApiClient from '../../src/identityApiClient';
+import { MParticleWebSDK } from '../../src/sdkRuntimeModels';
+
+describe('Identity Api Client', () => {
+    describe('#getUploadUrl', () => {
+        it.only('should generate an upload url with defaults', () => {
+            const mockSDK = ({
+                _Helpers: {
+                    createServiceUrl: () => 'https://identity.mparticle.com/',
+                },
+                _Store: {
+                },
+                _Persistence: {
+                },
+            } as unknown) as MParticleWebSDK;
+
+            const identityApiClient = new IdentityApiClient(mockSDK);
+
+            const url = identityApiClient.getUploadUrl();
+            expect(url).toBe('https://identity.mparticle.com/v1/identify');
+        });
+    });
+    describe('#sendIdentityRequest', () => {
+
+    });
+});