remove time on site tracking dependency on noTargeting privacy flag

Author: jaissica12

src/constants.ts

@@ -236,9 +236,8 @@ export const HTTP_SERVER_ERROR = 500 as const;
 
 export type PrivacyControl = 'functional' | 'targeting';
 
-export type StorageTypes = 'SDKState' | 'TimeOnSite';
+export type StorageTypes = 'SDKState';
 
 export const StoragePrivacyMap: Record<StorageTypes, PrivacyControl> = {
-    SDKState: 'functional',
-    TimeOnSite: 'targeting',
+    SDKState: 'functional'
 };

src/store.ts

@@ -749,9 +749,7 @@ export default function Store(
 
         if (workspaceToken) {
             this.SDKConfig.workspaceToken = workspaceToken;
-            if (!this.getPrivacyFlag('TimeOnSite')) {
-                mpInstance._timeOnSiteTimer = new ForegroundTimer(workspaceToken);
-            }
+            mpInstance._timeOnSiteTimer = new ForegroundTimer(workspaceToken);
         } else {
             mpInstance.Logger.warning(
                 'You should have a workspaceToken on your config object for security purposes.'

test/jest/foregroundTimeTracker.spec.ts

@@ -1,7 +1,4 @@
 import ForegroundTimeTracker from '../../src/foregroundTimeTracker';
-import Store, { IStore } from '../../src/store';
-import { SDKInitConfig } from '../../src/sdkRuntimeModels';
-import { IMParticleWebSDKInstance } from '../../src/mp-instance';
 
 describe('ForegroundTimeTracker', () => {
     let foregroundTimeTracker: ForegroundTimeTracker;
@@ -493,65 +490,4 @@ describe('ForegroundTimeTracker', () => {
             expect(updatePersistenceSpy).toHaveBeenCalled();
         });
     });
-
-    describe('#privacy flags', () => {
-        const workspaceToken = 'abcdef';
-        const tosKey = `mprtcl-tos-${workspaceToken}`;
-        let mockMPInstance: IMParticleWebSDKInstance;
-        let store: IStore;
-
-        beforeEach(() => {
-            jest.useFakeTimers({ now: Date.now(), advanceTimers: true });
-            localStorage.clear();
-
-            mockMPInstance = {
-                _Helpers: {
-                    createMainStorageName: () => `mprtcl-v4_${workspaceToken}`,
-                    createProductStorageName: () => `mprtcl-prodv4_${workspaceToken}`,
-                    Validators: { isFunction: () => true },
-                    extend: Object.assign,
-                },
-                _NativeSdkHelpers: { isWebviewEnabled: () => false },
-                _Persistence: {
-                    update: jest.fn(),
-                    savePersistence: jest.fn(),
-                    getPersistence: () => ({ gs: {} }),
-                },
-                Logger: { verbose: jest.fn(), warning: jest.fn(), error: jest.fn() },
-                Identity: { getCurrentUser: () => ({ getMPID: () => 'mpid' }) },
-                _timeOnSiteTimer: undefined as any,
-            } as unknown as IMParticleWebSDKInstance;
-
-            store = {} as IStore;
-            (Store as any).call(store, {} as SDKInitConfig, mockMPInstance, 'apikey');
-            mockMPInstance._Store = store;
-        });
-
-        afterEach(() => {
-            jest.useRealTimers();
-            localStorage.clear();
-        });
-
-        it('should track time on site when noTargeting is false by default', () => {
-            store.processConfig({ workspaceToken } as SDKInitConfig);
-            expect(mockMPInstance._timeOnSiteTimer).toBeDefined();
-            jest.advanceTimersByTime(1000);
-            mockMPInstance._timeOnSiteTimer.getTimeInForeground();
-            expect(localStorage.getItem(tosKey)).not.toBeNull();
-        });
-
-        it('should NOT track time on site when noTargeting is true', () => {
-            store.processConfig({ workspaceToken, launcherOptions: { noTargeting: true } } as SDKInitConfig);
-            expect(mockMPInstance._timeOnSiteTimer).toBeUndefined();
-            expect(localStorage.getItem(tosKey)).toBeNull();
-        });
-
-        it('should track time on site when noTargeting is false', () => {
-            store.processConfig({ workspaceToken, launcherOptions: { noTargeting: false } } as SDKInitConfig);
-            expect(mockMPInstance._timeOnSiteTimer).toBeDefined();
-            jest.advanceTimersByTime(1000);
-            mockMPInstance._timeOnSiteTimer.getTimeInForeground();
-            expect(localStorage.getItem(tosKey)).not.toBeNull();
-        });
-    });
 });