Skip to content

Commit e3f4cb7

Browse files
refactor: Remove Cookie Sync Interfaces File (#961)
1 parent efe0b60 commit e3f4cb7

File tree

8 files changed

+46
-48
lines changed

8 files changed

+46
-48
lines changed

src/configAPIClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import {
1313
FetchUploader,
1414
XHRUploader,
1515
} from './uploaders';
16-
import { IPixelConfiguration } from './cookieSyncManager.interfaces';
16+
import { IPixelConfiguration } from './cookieSyncManager';
1717

1818
export interface IKitConfigs extends IKitFilterSettings {
1919
name: string;

src/cookieSyncManager.interfaces.ts

Lines changed: 0 additions & 39 deletions
This file was deleted.

src/cookieSyncManager.ts

Lines changed: 37 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
import { isEmpty, replaceAmpWithAmpersand, replaceMPID } from './utils';
1+
import { Dictionary, isEmpty, replaceAmpWithAmpersand, replaceMPID } from './utils';
22
import Constants from './constants';
3-
import { CookieSyncDates, ICookieSyncManager, IPixelConfiguration } from './cookieSyncManager.interfaces';
43
import { MParticleWebSDK } from './sdkRuntimeModels';
54
import { MPID } from '@mparticle/web-sdk';
65
import { IConsentRules } from './consent';
@@ -10,6 +9,42 @@ const { InformationMessages } = Messages;
109

1110
export const DAYS_IN_MILLISECONDS = 1000 * 60 * 60 * 24;
1211

12+
export type CookieSyncDates = Dictionary<number>;
13+
14+
export interface IPixelConfiguration {
15+
name?: string;
16+
moduleId: number;
17+
esId?: number;
18+
isDebug?: boolean;
19+
isProduction?: boolean;
20+
settings: Dictionary<string>;
21+
frequencyCap: number;
22+
pixelUrl: string;
23+
redirectUrl: string;
24+
filteringConsentRuleValues?: IConsentRules;
25+
}
26+
export interface ICookieSyncManager {
27+
attemptCookieSync: (
28+
previousMPID: MPID,
29+
mpid: MPID,
30+
mpidIsNotInCookies?: boolean
31+
) => void;
32+
performCookieSync: (
33+
url: string,
34+
moduleId: string,
35+
mpid: MPID,
36+
cookieSyncDates: CookieSyncDates,
37+
filteringConsentRuleValues: IConsentRules,
38+
mpidIsNotInCookies: boolean,
39+
requiresConsent: boolean
40+
) => void;
41+
combineUrlWithRedirect: (
42+
mpid: MPID,
43+
pixelUrl: string,
44+
redirectUrl: string
45+
) => string;
46+
}
47+
1348
const hasFrequencyCapExpired = (
1449
frequencyCap: number,
1550
lastSyncDate?: number,

src/persistence.interfaces.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import {
1414
import { Dictionary } from './utils';
1515
import { IMinifiedConsentJSONObject } from './consent';
1616
import { UserAttributes } from './identity-user-interfaces';
17-
import { CookieSyncDates } from './cookieSyncManager.interfaces';
17+
import { CookieSyncDates } from './cookieSyncManager';
1818

1919
export type UploadsTable = Dictionary<any>;
2020
export interface iForwardingStatsBatches {

src/sdkRuntimeModels.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import {
3232
import { IIdentityType } from './types.interfaces';
3333
import IntegrationCapture from './integrationCapture';
3434
import { INativeSdkHelpers } from './nativeSdkHelpers.interfaces';
35-
import { ICookieSyncManager, IPixelConfiguration } from './cookieSyncManager.interfaces';
35+
import { ICookieSyncManager, IPixelConfiguration } from './cookieSyncManager';
3636

3737
// TODO: Resolve this with version in @mparticle/web-sdk
3838
export type SDKEventCustomFlags = Dictionary<any>;

src/store.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import {
3737
IGlobalStoreV2MinifiedKeys,
3838
IPersistenceMinified,
3939
} from './persistence.interfaces';
40-
import { CookieSyncDates, IPixelConfiguration } from './cookieSyncManager.interfaces';
40+
import { CookieSyncDates, IPixelConfiguration } from './cookieSyncManager';
4141

4242
// This represents the runtime configuration of the SDK AFTER
4343
// initialization has been complete and all settings and

test/jest/cookieSyncManager.spec.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1-
import CookieSyncManager, { DAYS_IN_MILLISECONDS } from '../../src/cookieSyncManager';
2-
import { IPixelConfiguration } from '../../src/cookieSyncManager.interfaces';
1+
import CookieSyncManager, {
2+
DAYS_IN_MILLISECONDS,
3+
IPixelConfiguration,
4+
} from '../../src/cookieSyncManager';
35
import { MParticleWebSDK } from '../../src/sdkRuntimeModels';
46
import { testMPID } from '../src/config/constants';
57

test/src/tests-cookie-syncing.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import fetchMock from 'fetch-mock/esm/client';
44
import { urls, testMPID, MPConfig, v4LSKey, apiKey } from './config/constants';
55
import { MParticleWebSDK } from '../../src/sdkRuntimeModels';
66
import { IMParticleUser } from '../../src/identity-user-interfaces';
7-
import { IPixelConfiguration } from '../../src/cookieSyncManager.interfaces';
7+
import { IPixelConfiguration } from '../../src/cookieSyncManager';
88
import { IConsentRules } from '../../src/consent';
99
const { fetchMockSuccess, waitForCondition, hasIdentifyReturned } = Utils;
1010

0 commit comments

Comments
 (0)