Address PR Comments

Author: alexs-mparticle

test/jest/types.spec.ts

@@ -180,10 +180,6 @@ describe('CommerceEventType', () => {
         expect(ProductRemoveFromWishlist).toEqual(21);
         expect(ProductImpression).toEqual(22);
     });
-
-    describe('#getName', () => {
-
-    });
 });
 
 describe('IdentityType', () => {
@@ -221,7 +217,8 @@ describe('IdentityType', () => {
         expect(Yahoo).toEqual(6);
         expect(Email).toEqual(7);
 
-        // There is no value for 8
+        // 8 was used for `Alias` but this is now hanled by Identity directly
+        // and will no longer be sent as an IdentityType
 
         expect(FacebookCustomAudienceId).toEqual(9);
         expect(Other2).toEqual(10);
@@ -303,7 +300,7 @@ describe('IdentityType', () => {
         });
     });
 
-    describe('#getNewIdentitesByName', () => {
+    describe('#getNewIdentitiesByName', () => {
         it('returns an identity name when passing an identity type', () => {
             const { getNewIdentitiesByName } = IdentityType;
 
@@ -318,16 +315,29 @@ describe('IdentityType', () => {
             });
         });
 
-        it('returns an empty object if the identity type is not found', () => {
+        it('returns an empty object if identity types are not found', () => {
             const { getNewIdentitiesByName } = IdentityType;
 
             const newIdentitiesByType = {
-                [NaN]: 'not-a-number',
                 ['invalid']: 'not-valid',
             };
 
             expect(getNewIdentitiesByName(newIdentitiesByType)).toEqual({});
         });
+
+        it('removes invalid identity types', () => {
+            const { getNewIdentitiesByName } = IdentityType;
+
+            const newIdentitiesByType = {
+                [NaN]: 'not-a-number',
+                ['invalid']: 'not-valid',
+                [Email]: 'bar@gmail.com',
+            };
+
+            expect(getNewIdentitiesByName(newIdentitiesByType)).toEqual({
+                email: 'bar@gmail.com',
+            });
+        });
     });
 
     describe('#getIdentityName', () => {
@@ -380,6 +390,7 @@ describe('IdentityType', () => {
             expect(getName(FacebookCustomAudienceId)).toBe('Facebook App User ID');
         }); 
 
+        // https://go.mparticle.com/work/SQDSDKS-6942
         it('returns other if the identity type is not found', () => {
             const { getName } = IdentityType;