Skip to content

Commit e7c10ee

Browse files
committed
refactor: Update logging calls to use the new Logger instance directly
1 parent 2bac35c commit e7c10ee

File tree

3 files changed

+12
-15
lines changed

3 files changed

+12
-15
lines changed

src/batchUploader.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -259,15 +259,13 @@ export class BatchUploader {
259259
return;
260260
}
261261

262-
const { verbose } = this.mpInstance.Logger;
263-
264262
this.eventsQueuedForProcessing.push(event);
265263
if (this.offlineStorageEnabled && this.eventVault) {
266264
this.eventVault.store(this.eventsQueuedForProcessing);
267265
}
268266

269-
verbose(`Queuing event: ${JSON.stringify(event)}`);
270-
verbose(`Queued event count: ${this.eventsQueuedForProcessing.length}`);
267+
this.mpInstance.Logger.verbose(`Queuing event: ${JSON.stringify(event)}`);
268+
this.mpInstance.Logger.verbose(`Queued event count: ${this.eventsQueuedForProcessing.length}`);
271269

272270
if (this.shouldTriggerImmediateUpload(event.EventDataType)) {
273271
this.prepareAndUpload(false, false);

src/identityApiClient.ts

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -88,12 +88,11 @@ export default function IdentityAPIClient(
8888
aliasRequest: IAliasRequest,
8989
aliasCallback: IAliasCallback
9090
) {
91-
const { verbose, error } = mpInstance.Logger;
9291
const { invokeAliasCallback } = mpInstance._Helpers;
9392
const { aliasUrl } = mpInstance._Store.SDKConfig;
9493
const { devToken: apiKey } = mpInstance._Store;
9594

96-
verbose(Messages.InformationMessages.SendAliasHttp);
95+
mpInstance.Logger.verbose(Messages.InformationMessages.SendAliasHttp);
9796

9897
// https://go.mparticle.com/work/SQDSDKS-6750
9998
const uploadUrl = `https://${aliasUrl}${apiKey}/Alias`;
@@ -136,7 +135,7 @@ export default function IdentityAPIClient(
136135
try {
137136
aliasResponseBody = await response.json();
138137
} catch (e) {
139-
verbose('The request has no response body');
138+
mpInstance.Logger.verbose('The request has no response body');
140139
}
141140
} else {
142141
// https://go.mparticle.com/work/SQDSDKS-6568
@@ -171,11 +170,11 @@ export default function IdentityAPIClient(
171170

172171
}
173172

174-
verbose(message);
173+
mpInstance.Logger.verbose(message);
175174
invokeAliasCallback(aliasCallback, response.status, errorMessage);
176175
} catch (e) {
177176
const errorMessage = (e as Error).message || e.toString();
178-
error('Error sending alias request to mParticle servers. ' + errorMessage);
177+
mpInstance.Logger.error('Error sending alias request to mParticle servers. ' + errorMessage);
179178
invokeAliasCallback(
180179
aliasCallback,
181180
HTTPCodes.noHttpCoverage,
@@ -193,15 +192,14 @@ export default function IdentityAPIClient(
193192
mpid: MPID,
194193
knownIdentities: UserIdentities
195194
) {
196-
const { verbose, error } = mpInstance.Logger;
197195
const { invokeCallback } = mpInstance._Helpers;
198196

199-
verbose(Messages.InformationMessages.SendIdentityBegin);
197+
mpInstance.Logger.verbose(Messages.InformationMessages.SendIdentityBegin);
200198
if (!identityApiRequest) {
201-
error(Messages.ErrorMessages.APIRequestEmpty);
199+
mpInstance.Logger.error(Messages.ErrorMessages.APIRequestEmpty);
202200
return;
203201
}
204-
verbose(Messages.InformationMessages.SendIdentityHttp);
202+
mpInstance.Logger.verbose(Messages.InformationMessages.SendIdentityHttp);
205203

206204
if (mpInstance._Store.identityCallInFlight) {
207205
invokeCallback(
@@ -289,7 +287,7 @@ export default function IdentityAPIClient(
289287

290288
mpInstance._Store.identityCallInFlight = false;
291289

292-
verbose(message);
290+
mpInstance.Logger.verbose(message);
293291
parseIdentityResponse(
294292
identityResponse,
295293
previousMPID,
@@ -304,7 +302,7 @@ export default function IdentityAPIClient(
304302

305303
const errorMessage = (err as Error).message || err.toString();
306304

307-
error('Error sending identity request to servers' + ' - ' + errorMessage);
305+
mpInstance.Logger.error('Error sending identity request to servers' + ' - ' + errorMessage);
308306
invokeCallback(
309307
callback,
310308
HTTPCodes.noHttpCoverage,

src/mp-instance.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,7 @@ export default function mParticleInstance(this: IMParticleWebSDKInstance, instan
227227
if (instance._Store) {
228228
delete instance._Store;
229229
}
230+
instance.Logger = new Logger(config);
230231
instance._Store = new Store(config, instance);
231232
instance._Store.isLocalStorageAvailable = instance._Persistence.determineLocalStorageAvailability(
232233
window.localStorage

0 commit comments

Comments
 (0)