refactor(mParticleInstance): Simplify initialization by removing kitBlocker parameter from related functions

Author: gtamanaha

src/mp-instance.ts

@@ -162,10 +162,7 @@ export default function mParticleInstance(this: IMParticleWebSDKInstance, instan
             );
         }
 
-        const kitBlocker = createKitBlocker(config, this);
-        runPreConfigFetchInitialization(this, apiKey, config, kitBlocker);
-        debugger;
-        this.Logger.error('gt error test');
+        runPreConfigFetchInitialization(this, apiKey, config);
 
         // config code - Fetch config when requestConfig = true, otherwise, proceed with SDKInitialization
         // Since fetching the configuration is asynchronous, we must pass completeSDKInitialization
@@ -188,10 +185,10 @@ export default function mParticleInstance(this: IMParticleWebSDKInstance, instan
                         result
                     );
 
-                    completeSDKInitialization(apiKey, mergedConfig, this, kitBlocker);
+                    completeSDKInitialization(apiKey, mergedConfig, this);
                 });
             } else {
-                completeSDKInitialization(apiKey, config, this, kitBlocker);
+                completeSDKInitialization(apiKey, config, this);
             }
         } else {
             console.error(
@@ -1364,9 +1361,11 @@ export default function mParticleInstance(this: IMParticleWebSDKInstance, instan
 }
 
 // Some (server) config settings need to be returned before they are set on SDKConfig in a self hosted environment
-function completeSDKInitialization(apiKey, config, mpInstance, kitBlocker: KitBlocker) {
+function completeSDKInitialization(apiKey, config, mpInstance) {
+    const kitBlocker = createKitBlocker(config, mpInstance);
     const { getFeatureFlag } = mpInstance._Helpers;
 
+    mpInstance._APIClient = new APIClient(mpInstance, kitBlocker);
     mpInstance._Forwarders = new Forwarders(mpInstance, kitBlocker);
     mpInstance._Store.processConfig(config);
 
@@ -1550,9 +1549,8 @@ function createIdentityCache(mpInstance) {
     });
 }
 
-function runPreConfigFetchInitialization(mpInstance, apiKey, config, kitBlocker: KitBlocker) {
-    mpInstance._APIClient = new APIClient(mpInstance, kitBlocker);
-    mpInstance.Logger = new Logger(config, mpInstance._APIClient);
+function runPreConfigFetchInitialization(mpInstance, apiKey, config) {
+    mpInstance.Logger = new Logger(config);
     mpInstance._Store = new Store(config, mpInstance, apiKey);
     window.mParticle.Store = mpInstance._Store;
     mpInstance.Logger.verbose(StartingInitialization);