Skip to content

Commit a8ed2cf

Browse files
fix: Update android impression/promotion handling (#76)
* fix: Update android impression/promotion handling * fix: android unit test compilation error Co-authored-by: Will Passidomo <[email protected]>
1 parent 420a75b commit a8ed2cf

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

android/src/main/java/com/mparticle/react/MParticleModule.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -587,7 +587,7 @@ else if (isPromotion) {
587587
Promotion promotion = ConvertPromotion(promotionMap);
588588
builder = new CommerceEvent.Builder(promotionAction, promotion);
589589

590-
for (int i = 0; i < promotionsReadableArray.size(); ++i) {
590+
for (int i = 1; i < promotionsReadableArray.size(); ++i) {
591591
promotionMap = promotionsReadableArray.getMap(i);
592592
promotion = ConvertPromotion(promotionMap);
593593
builder.addPromotion(promotion);
@@ -599,7 +599,7 @@ else if (isPromotion) {
599599
Impression impression = ConvertImpression(impressionMap);
600600
builder = new CommerceEvent.Builder(impression);
601601

602-
for (int i = 0; i < impressionsArray.size(); ++i) {
602+
for (int i = 1; i < impressionsArray.size(); ++i) {
603603
impressionMap = impressionsArray.getMap(i);
604604
impression = ConvertImpression(impressionMap);
605605
builder.addImpression(impression);

android/src/test/java/com/mparticle/react/testutils/MockMParticleUser.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
import com.mparticle.MParticle;
77
import com.mparticle.UserAttributeListener;
8+
import com.mparticle.UserAttributeListenerType;
89
import com.mparticle.consent.ConsentState;
910
import com.mparticle.identity.MParticleUser;
1011

@@ -33,7 +34,7 @@ public Map<String, Object> getUserAttributes() {
3334

3435
@Nullable
3536
@Override
36-
public Map<String, Object> getUserAttributes(@Nullable UserAttributeListener userAttributeListener) {
37+
public Map<String, Object> getUserAttributes(@Nullable UserAttributeListenerType userAttributeListener) {
3738
return null;
3839
}
3940

@@ -59,7 +60,7 @@ public boolean setUserAttributeList(@NonNull String s, @NonNull Object o) {
5960
}
6061

6162
@Override
62-
public boolean incrementUserAttribute(@NonNull String s, int i) {
63+
public boolean incrementUserAttribute(@NonNull String s, Number i) {
6364
return false;
6465
}
6566

0 commit comments

Comments
 (0)