Skip to content

Commit d89d8be

Browse files
committed
Fixed bug when publisher field was null
1 parent 0d4bf11 commit d89d8be

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/api/apis/ComicVineAPI.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ export class ComicVineAPI extends APIModel {
4040
englishTitle: result.name,
4141
year: result.start_year,
4242
dataSource: this.apiName,
43-
id: result.id,
44-
publishers: result.publisher.name ?? [],
43+
id: `4050-${result.id}`,
44+
publishers: result.publisher?.name ?? [],
4545
}),
4646
);
4747
}
@@ -52,7 +52,7 @@ export class ComicVineAPI extends APIModel {
5252
async getById(id: string): Promise<MediaTypeModel> {
5353
console.log(`MDB | api "${this.apiName}" queried by ID`);
5454

55-
const searchUrl = `${this.apiUrl}/volume/4050-${encodeURIComponent(id)}/?api_key=${this.plugin.settings.ComicVineKey}&format=json`;
55+
const searchUrl = `${this.apiUrl}/volume/${encodeURIComponent(id)}/?api_key=${this.plugin.settings.ComicVineKey}&format=json`;
5656
const fetchData = await requestUrl({
5757
url: searchUrl,
5858
});
@@ -76,15 +76,15 @@ export class ComicVineAPI extends APIModel {
7676
year: result.start_year ?? '',
7777
dataSource: this.apiName,
7878
url: result.site_detail_url,
79-
id: result.id,
79+
id: `4050-${result.id}`,
8080

8181

8282
authors: result.people?.map((x: any) => x.name) ?? [],
8383
chapters: result.count_of_issues,
8484
image: result.image?.original_url ?? '',
8585

8686
released: true,
87-
publishers: result.publisher.name ?? [],
87+
publishers: result.publisher?.name ?? [],
8888
publishedFrom: result.start_year ?? 'unknown',
8989
publishedTo: 'unknown',
9090
status: result.status,

0 commit comments

Comments
 (0)