properly handle block refs in links

Author: mProjectsCode

automation/build/esbuild.config.ts

@@ -35,6 +35,7 @@ const build = await esbuild.build({
 	outfile: 'main.js',
 	minify: true,
 	metafile: true,
+	conditions: ['browser', 'production'],
 	define: {
 		MB_DEV_BUILD: 'false',
 		MB_DEBUG: 'false',

automation/build/esbuild.dev.config.ts

@@ -34,6 +34,7 @@ const context = await esbuild.context({
 	treeShaking: true,
 	outdir: `exampleVault/.obsidian/plugins/${manifest.id}/`,
 	outbase: 'packages/obsidian/src',
+	conditions: ['browser', 'development'],
 	define: {
 		MB_DEV_BUILD: 'false',
 		MB_DEBUG: 'true',

exampleVault/View Fields/View Field.md

@@ -12,8 +12,8 @@ object:
   key: value
 file: Example Note with Embeds
 image: Other/Images/subfolder/img_frozen_branch.jpg
-someInputValue: 2
-someComputedValue: 4
+someInputValue: 1
+someComputedValue: 2
 images:
   - Other/Images/img_flower.webp
   - Other/Images/img_butterfly.webp

packages/core/src/fields/button/ButtonActionRunner.ts

@@ -54,14 +54,17 @@ export class ButtonActionRunner {
 		};
 	}
 
-	resolveFilePath(filePath: string, relativeFilePath?: string): string {
+	/**
+	 * Resolves a file name, path or link to a file path.
+	 */
+	resolveFilePath(filePath: string, relativeTo?: string): string {
 		const targetFilePath = MDLinkParser.isLink(filePath) ? MDLinkParser.parseLink(filePath).target : filePath;
-		const resolvedFilePath = this.plugin.internal.file.getPathByName(targetFilePath, relativeFilePath);
+		const resolvedFilePath = this.plugin.internal.file.getPathByName(targetFilePath, relativeTo);
 		if (resolvedFilePath === undefined) {
 			throw new MetaBindParsingError({
 				errorLevel: ErrorLevel.ERROR,
 				cause: `Could not find a file that matches "${filePath}".`,
-				effect: `Could not resolve path or link "${filePath}" relative to "${relativeFilePath}".`,
+				effect: `Could not resolve path or link "${filePath}" relative to "${relativeTo}".`,
 			});
 		}
 

packages/core/src/parsers/MarkdownLinkParser.ts

@@ -9,11 +9,9 @@ import { isUrl, openURL } from 'packages/core/src/utils/Utils';
 const P_MDLinkInner: Parser<[string, string | undefined, string | undefined]> = P.sequence(
 	P_FilePath, // the file path
 	P.or(
-		P.string('#^')
-			.then(P.manyNotOf('[]#|^:'))
-			.map(x => '^' + x), // the optional block
-		P.string('#').then(P.manyNotOf('[]#|^:')), // the optional heading
-		P.succeed(undefined),
+		P.string('#').then(P.manyNotOf('[]#|:')), // either a heading with maybe a block
+		P.string('#').result(undefined), // or an empty heading
+		P.succeed(undefined), // or no heading at all
 	),
 	P.string('|').then(P.manyNotOf('[]')).optional(), // the optional alias
 );

tests/parserTests/MarkdownLinkParser.test.ts

@@ -41,7 +41,7 @@ describe('markdown link parser', () => {
 			);
 		});
 
-		test('should parse wiki with block', () => {
+		test('should parse wiki with heading', () => {
 			expect(MDLinkParser.parseLink('[[test#123]]')).toEqual(
 				toLink({
 					isEmbed: false,
@@ -53,6 +53,66 @@ describe('markdown link parser', () => {
 			);
 		});
 
+		test('should parse wiki with only heading', () => {
+			expect(MDLinkParser.parseLink('[[#123]]')).toEqual(
+				toLink({
+					isEmbed: false,
+					target: '',
+					block: '123',
+					alias: undefined,
+					internal: true,
+				}),
+			);
+		});
+
+		test('should parse wiki with block', () => {
+			expect(MDLinkParser.parseLink('[[test#^123]]')).toEqual(
+				toLink({
+					isEmbed: false,
+					target: 'test',
+					block: '^123',
+					alias: undefined,
+					internal: true,
+				}),
+			);
+		});
+
+		test('should parse wiki only block', () => {
+			expect(MDLinkParser.parseLink('[[#^123]]')).toEqual(
+				toLink({
+					isEmbed: false,
+					target: '',
+					block: '^123',
+					alias: undefined,
+					internal: true,
+				}),
+			);
+		});
+
+		test('should parse wiki with heading and block', () => {
+			expect(MDLinkParser.parseLink('[[test#123^456]]')).toEqual(
+				toLink({
+					isEmbed: false,
+					target: 'test',
+					block: '123^456',
+					alias: undefined,
+					internal: true,
+				}),
+			);
+		});
+
+		test('should parse wiki with only heading and block', () => {
+			expect(MDLinkParser.parseLink('[[#123^456]]')).toEqual(
+				toLink({
+					isEmbed: false,
+					target: '',
+					block: '123^456',
+					alias: undefined,
+					internal: true,
+				}),
+			);
+		});
+
 		test('should parse wiki with alias', () => {
 			expect(MDLinkParser.parseLink('[[test|something]]')).toEqual(
 				toLink({