fix eslint

mProjectsCode · mProjectsCode · commit 55c3e853040f · 2022-11-29T19:45:15.000+01:00
diff --git a/.eslintrc b/.eslintrc
@@ -4,24 +4,19 @@
 	"env": {
 		"node": true
 	},
-	"plugins": ["@typescript-eslint"],
+	"plugins": ["@typescript-eslint", "only-warn"],
 	"extends": ["eslint:recommended", "plugin:@typescript-eslint/eslint-recommended", "plugin:@typescript-eslint/recommended"],
 	"parserOptions": {
 		"sourceType": "module"
 	},
 	"rules": {
 		"no-unused-vars": "off",
-		"@typescript-eslint/no-unused-vars": [
-			"error",
-			{
-				"args": "none"
-			}
-		],
+		"@typescript-eslint/no-unused-vars": ["error", { "args": "none" }],
 		"@typescript-eslint/ban-ts-comment": "off",
 		"no-prototype-builtins": "off",
-		"no-useless-escape": "off",
-		"@typescript-eslint/no-inferrable-types": "off",
 		"@typescript-eslint/no-empty-function": "off",
-		"@typescript-eslint/explicit-function-return-type": ["error"]
+		"@typescript-eslint/no-inferrable-types": "off",
+		"@typescript-eslint/no-explicit-any": "off",
+		"@typescript-eslint/explicit-function-return-type": ["warn"]
 	}
 }
diff --git a/esbuild.config.mjs b/esbuild.config.mjs
@@ -47,7 +47,7 @@ esbuild
 		],
 		format: 'cjs',
 		watch: !prod,
-		target: 'es2016',
+		target: 'es2018',
 		logLevel: 'info',
 		sourcemap: prod ? false : 'inline',
 		treeShaking: true,
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -8,7 +8,8 @@
 		"build": "tsc -noEmit -skipLibCheck && node esbuild.config.mjs production",
 		"version": "node version-bump.mjs && git add manifest.json versions.json",
 		"test": "jest",
-		"format": "prettier --write ."
+		"format": "prettier --write .",
+		"lint": "eslint --max-warnings=0 src/**"
 	},
 	"keywords": [],
 	"author": "Moritz Jung",
@@ -23,6 +24,7 @@
 		"esbuild": "^0.14.47",
 		"esbuild-plugin-copy-watch": "^0.0.7",
 		"esbuild-svelte": "^0.7.1",
+		"eslint-plugin-only-warn": "^1.0.3",
 		"jest": "^28.1.1",
 		"jest-environment-jsdom": "^28.1.1",
 		"obsidian": "latest",
diff --git a/src/InputFieldMarkdownRenderChild.ts b/src/InputFieldMarkdownRenderChild.ts
@@ -215,7 +215,7 @@ export class InputFieldMarkdownRenderChild extends MarkdownRenderChild {
 
 		if (this.error) {
 			this.containerEl.empty();
-			const originalText = this.containerEl.createEl('span', { text: this.fullDeclaration, cls: 'meta-bind-code' });
+			this.containerEl.createEl('span', { text: this.fullDeclaration, cls: 'meta-bind-code' });
 			container.innerText = ` -> ERROR: ${this.error}`;
 			container.addClass('meta-bind-plugin-error');
 			this.containerEl.appendChild(container);
@@ -224,7 +224,7 @@ export class InputFieldMarkdownRenderChild extends MarkdownRenderChild {
 
 		if (!this.inputField) {
 			this.containerEl.empty();
-			const originalText = this.containerEl.createEl('span', { text: this.fullDeclaration, cls: 'meta-bind-code' });
+			this.containerEl.createEl('span', { text: this.fullDeclaration, cls: 'meta-bind-code' });
 			container.innerText = ` -> ERROR: ${new MetaBindInternalError('input field is undefined and error is empty').message}`;
 			container.addClass('meta-bind-plugin-error');
 			this.containerEl.appendChild(container);
diff --git a/src/inputFieldArguments/AbstractInputFieldArgument.ts b/src/inputFieldArguments/AbstractInputFieldArgument.ts
@@ -17,7 +17,7 @@ export abstract class AbstractInputFieldArgument {
 		return this.allowedInputFields.contains(inputFieldType);
 	}
 
-	getAllowedInputFieldsAsString() {
+	getAllowedInputFieldsAsString(): string {
 		return this.allowedInputFields.length === 0 ? 'all' : this.allowedInputFields.join(', ');
 	}
 }
diff --git a/src/inputFieldArguments/InputFieldArgumentContainer.ts b/src/inputFieldArguments/InputFieldArgumentContainer.ts
@@ -18,7 +18,7 @@ export class InputFieldArgumentContainer {
 		for (const argument of this.arguments) {
 			map[argument.identifier] += 1;
 			if (map[argument.identifier] > 1 && !argument.allowMultiple) {
-				throw new MetaBindParsingError(`argument \'${argument.identifier}\' does not allow duplicates`);
+				throw new MetaBindParsingError(`argument '${argument.identifier}' does not allow duplicates`);
 			}
 		}
 	}
diff --git a/src/inputFields/DateInputField.ts b/src/inputFields/DateInputField.ts
@@ -64,7 +64,7 @@ export class DateInputField extends AbstractInputField {
 
 		this.date = DateParser.parse(value);
 		if (!this.date) {
-			console.warn(new MetaBindBindValueError(`invalid value \'${value}\' at dateInputField ${this.inputFieldMarkdownRenderChild.uid}`));
+			console.warn(new MetaBindBindValueError(`invalid value '${value}' at dateInputField ${this.inputFieldMarkdownRenderChild.uid}`));
 			this.date = DateParser.getDefaultDate();
 		}
 
diff --git a/src/inputFields/InputFieldFactory.ts b/src/inputFields/InputFieldFactory.ts
@@ -99,10 +99,10 @@ export class InputFieldFactory {
 	static checkInputFieldMarkdownRenderChildTypeAllowed(inputFieldType: InputFieldType, type: InputFieldMarkdownRenderChildType): void {
 		const allowCodeBlock: { codeBlock: boolean; inlineCodeBlock: boolean } = InputFieldFactory.allowCodeBlockMap[inputFieldType];
 		if (type === InputFieldMarkdownRenderChildType.CODE_BLOCK && !allowCodeBlock.codeBlock) {
-			throw new MetaBindParsingError(`\'${inputFieldType}\' is not allowed as code block`);
+			throw new MetaBindParsingError(`'${inputFieldType}' is not allowed as code block`);
 		}
 		if (type === InputFieldMarkdownRenderChildType.INLINE_CODE_BLOCK && !allowCodeBlock.inlineCodeBlock) {
-			throw new MetaBindParsingError(`\'${inputFieldType}\' is not allowed as inline code block`);
+			throw new MetaBindParsingError(`'${inputFieldType}' is not allowed as inline code block`);
 		}
 	}
 }
diff --git a/src/inputFields/NumberInputField.ts b/src/inputFields/NumberInputField.ts
@@ -21,7 +21,7 @@ export class NumberInputField extends AbstractInputField {
 		if (value != null && (typeof value == 'number' || typeof value == 'string')) {
 			this.numberComponent.setValue(numberToString(value));
 		} else {
-			console.warn(new MetaBindBindValueError(`invalid value \'${value}\' at numberInputField ${this.inputFieldMarkdownRenderChild.uid}`));
+			console.warn(new MetaBindBindValueError(`invalid value '${value}' at numberInputField ${this.inputFieldMarkdownRenderChild.uid}`));
 			this.numberComponent.setValue(this.getDefaultValue());
 		}
 	}
diff --git a/src/inputFields/SliderInputField.ts b/src/inputFields/SliderInputField.ts
@@ -33,7 +33,7 @@ export class SliderInputField extends AbstractInputField {
 				this.sliderComponent.setValue(value);
 			}
 		} else {
-			console.warn(new MetaBindBindValueError(`invalid value \'${value}\' at sliderInputField ${this.inputFieldMarkdownRenderChild.uid}`));
+			console.warn(new MetaBindBindValueError(`invalid value '${value}' at sliderInputField ${this.inputFieldMarkdownRenderChild.uid}`));
 			this.sliderComponent.setValue(this.getDefaultValue());
 		}
 	}
diff --git a/src/inputFields/TextAreaInputField.ts b/src/inputFields/TextAreaInputField.ts
@@ -21,7 +21,7 @@ export class TextAreaInputField extends AbstractInputField {
 		if (value != null && typeof value == 'string') {
 			this.textAreaComponent.setValue(value);
 		} else {
-			console.warn(new MetaBindBindValueError(`invalid value \'${value}\' at textAreaInputField ${this.inputFieldMarkdownRenderChild.uid}`));
+			console.warn(new MetaBindBindValueError(`invalid value '${value}' at textAreaInputField ${this.inputFieldMarkdownRenderChild.uid}`));
 			this.textAreaComponent.setValue('');
 		}
 	}
diff --git a/src/inputFields/TextInputField.ts b/src/inputFields/TextInputField.ts
@@ -21,7 +21,7 @@ export class TextInputField extends AbstractInputField {
 		if (value != null && typeof value == 'string') {
 			this.textComponent.setValue(value);
 		} else {
-			console.warn(new MetaBindBindValueError(`invalid value \'${value}\' at textInputField ${this.inputFieldMarkdownRenderChild.uid}`));
+			console.warn(new MetaBindBindValueError(`invalid value '${value}' at textInputField ${this.inputFieldMarkdownRenderChild.uid}`));
 			this.textComponent.setValue('');
 		}
 	}
diff --git a/src/inputFields/TimeInputField.ts b/src/inputFields/TimeInputField.ts
@@ -52,7 +52,7 @@ export class TimeInputField extends AbstractInputField {
 
 		this.time = TimeParser.parse(value);
 		if (!this.time) {
-			console.warn(new MetaBindBindValueError(`invalid value \'${value}\' at timeInputField ${this.inputFieldMarkdownRenderChild.uid}`));
+			console.warn(new MetaBindBindValueError(`invalid value '${value}' at timeInputField ${this.inputFieldMarkdownRenderChild.uid}`));
 			this.time = TimeParser.getDefaultTime();
 		}
 		// console.log(this.time);
diff --git a/src/inputFields/ToggleInputField.ts b/src/inputFields/ToggleInputField.ts
@@ -20,7 +20,7 @@ export class ToggleInputField extends AbstractInputField {
 		if (value != null && typeof value == 'boolean') {
 			this.toggleComponent.setValue(value);
 		} else {
-			console.warn(new MetaBindBindValueError(`invalid value \'${value}\' at toggleInputField ${this.inputFieldMarkdownRenderChild.uid}`));
+			console.warn(new MetaBindBindValueError(`invalid value '${value}' at toggleInputField ${this.inputFieldMarkdownRenderChild.uid}`));
 			this.toggleComponent.setValue(false);
 		}
 	}
diff --git a/src/main.ts b/src/main.ts
@@ -1,11 +1,10 @@
-import { CachedMetadata, Plugin, TFile } from 'obsidian';
+import { CachedMetadata, FrontMatterCache, Plugin, TFile } from 'obsidian';
 import { DEFAULT_SETTINGS, MetaBindPluginSettings, MetaBindSettingTab } from './settings/Settings';
 import { InputFieldMarkdownRenderChild, InputFieldMarkdownRenderChildType } from './InputFieldMarkdownRenderChild';
-import { getFileName, isPath, removeFileEnding } from './utils/Utils';
+import { getFileName, isPath, MetaBindInternalError, removeFileEnding } from './utils/Utils';
 import { Logger } from './utils/Logger';
 import { DateParser } from './parsers/DateParser';
 import { InputFieldDeclarationParser } from './parsers/InputFieldDeclarationParser';
-import { getFrontmatterOfTFile } from '@opd-libs/opd-metadata-lib/lib/API';
 import { traverseObject } from '@opd-libs/opd-metadata-lib/lib/Utils';
 
 export default class MetaBindPlugin extends Plugin {
@@ -87,17 +86,19 @@ export default class MetaBindPlugin extends Plugin {
 	}
 
 	updateMarkdownInputFieldsOnMetadataCacheChange(file: TFile, cache: CachedMetadata): void {
-		let metadata: any = undefined;
+		const metadata: FrontMatterCache | undefined = cache.frontmatter;
+
+		if (!metadata) {
+			console.warn(new MetaBindInternalError(`Can not update metadata for input fields, received metadata is ${metadata}`));
+			return;
+		}
 
 		for (const activeMarkdownInputField of this.activeMarkdownInputFields) {
 			if (!activeMarkdownInputField.inputFieldDeclaration?.isBound || !activeMarkdownInputField.bindTargetFile || !activeMarkdownInputField.bindTargetMetadataField) {
 				continue;
 			}
 
 			if (activeMarkdownInputField.bindTargetFile.path === file.path) {
-				if (metadata === undefined) {
-					metadata = getFrontmatterOfTFile(file, this);
-				}
 				activeMarkdownInputField.pushToInputFieldValueUpdateQueue(traverseObject(activeMarkdownInputField.bindTargetMetadataField, metadata));
 			}
 		}
diff --git a/src/parsers/InputFieldDeclarationParser.ts b/src/parsers/InputFieldDeclarationParser.ts
@@ -57,7 +57,7 @@ export class InputFieldDeclarationParser {
 	static templates: Template[] = [];
 
 	static parse(fullDeclaration: string): InputFieldDeclaration {
-		let inputFieldDeclaration: InputFieldDeclaration = {} as InputFieldDeclaration;
+		const inputFieldDeclaration: InputFieldDeclaration = {} as InputFieldDeclaration;
 
 		let useTemplate = false;
 		let templateName = '';
@@ -115,7 +115,7 @@ export class InputFieldDeclarationParser {
 					inputFieldDeclaration.inputFieldType === InputFieldType.INVALID ? template.inputFieldType : inputFieldDeclaration.inputFieldType || template.inputFieldType;
 				inputFieldDeclaration.argumentContainer = template.argumentContainer.mergeByOverride(inputFieldDeclaration.argumentContainer);
 			} else {
-				throw new MetaBindParsingError(`unknown template name \'${templateName}\'`);
+				throw new MetaBindParsingError(`unknown template name '${templateName}'`);
 			}
 		}
 
@@ -164,7 +164,7 @@ export class InputFieldDeclarationParser {
 
 			if (!inputFieldArgument.isAllowed(inputFieldType)) {
 				throw new MetaBindParsingError(
-					`argument \'${inputFieldArgumentIdentifier}\' is only applicable to ${inputFieldArgument.getAllowedInputFieldsAsString()} input fields`
+					`argument '${inputFieldArgumentIdentifier}' is only applicable to ${inputFieldArgument.getAllowedInputFieldsAsString()} input fields`
 				);
 			}
 
@@ -189,7 +189,7 @@ export class InputFieldDeclarationParser {
 
 		const argumentValue = ParserUtils.getInBetween(argumentString, InputFieldDeclarationParser.roundBracesPair) as string;
 		if (!argumentValue) {
-			throw new MetaBindParsingError(`argument \'${argumentName}\' requires a non empty value`);
+			throw new MetaBindParsingError(`argument '${argumentName}' requires a non empty value`);
 		}
 
 		return argumentValue;
diff --git a/src/utils/Logger.ts b/src/utils/Logger.ts
diff --git a/src/utils/Utils.ts b/src/utils/Utils.ts
@@ -106,9 +106,7 @@ export function arrayEquals(arr1: any[], arr2: any[]): boolean {
  * @param dataModel
  */
 export function replaceTags(template: string, dataModel: any): string {
-	const resolvedTemplate = template.replace(new RegExp('{{.*?}}', 'g'), (match: string) => replaceTag(match, dataModel));
-
-	return resolvedTemplate;
+	return template.replace(new RegExp('{{.*?}}', 'g'), (match: string) => replaceTag(match, dataModel));
 }
 
 /**
@@ -191,6 +189,6 @@ export function equalOrIncludes(str1: string, str2: string): boolean {
 	return str1 === str2 || str1.includes(str2) || str2.includes(str1);
 }
 
-export function numberToString(n: number | string) {
+export function numberToString(n: number | string): string {
 	return n + '';
 }

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ export abstract class AbstractInputFieldArgument {`
`17`	`17`	`return this.allowedInputFields.contains(inputFieldType);`
`18`	`18`	`}`
`19`	`19`
`20`		`- getAllowedInputFieldsAsString() {`
	`20`	`+ getAllowedInputFieldsAsString(): string {`
`21`	`21`	`return this.allowedInputFields.length === 0 ? 'all' : this.allowedInputFields.join(', ');`
`22`	`22`	`}`
`23`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ export class InputFieldArgumentContainer {`
`18`	`18`	`for (const argument of this.arguments) {`
`19`	`19`	`map[argument.identifier] += 1;`
`20`	`20`	`if (map[argument.identifier] > 1 && !argument.allowMultiple) {`
`21`		- throw new MetaBindParsingError(`argument \'${argument.identifier}\' does not allow duplicates`);
	`21`	+ throw new MetaBindParsingError(`argument '${argument.identifier}' does not allow duplicates`);
`22`	`22`	`}`
`23`	`23`	`}`
`24`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ export class DateInputField extends AbstractInputField {`
`64`	`64`
`65`	`65`	`this.date = DateParser.parse(value);`
`66`	`66`	`if (!this.date) {`
`67`		- console.warn(new MetaBindBindValueError(`invalid value \'${value}\' at dateInputField ${this.inputFieldMarkdownRenderChild.uid}`));
	`67`	+ console.warn(new MetaBindBindValueError(`invalid value '${value}' at dateInputField ${this.inputFieldMarkdownRenderChild.uid}`));
`68`	`68`	`this.date = DateParser.getDefaultDate();`
`69`	`69`	`}`
`70`	`70`
Original file line number	Diff line number	Diff line change
`@@ -99,10 +99,10 @@ export class InputFieldFactory {`
`99`	`99`	`static checkInputFieldMarkdownRenderChildTypeAllowed(inputFieldType: InputFieldType, type: InputFieldMarkdownRenderChildType): void {`
`100`	`100`	`const allowCodeBlock: { codeBlock: boolean; inlineCodeBlock: boolean } = InputFieldFactory.allowCodeBlockMap[inputFieldType];`
`101`	`101`	`if (type === InputFieldMarkdownRenderChildType.CODE_BLOCK && !allowCodeBlock.codeBlock) {`
`102`		- throw new MetaBindParsingError(`\'${inputFieldType}\' is not allowed as code block`);
	`102`	+ throw new MetaBindParsingError(`'${inputFieldType}' is not allowed as code block`);
`103`	`103`	`}`
`104`	`104`	`if (type === InputFieldMarkdownRenderChildType.INLINE_CODE_BLOCK && !allowCodeBlock.inlineCodeBlock) {`
`105`		- throw new MetaBindParsingError(`\'${inputFieldType}\' is not allowed as inline code block`);
	`105`	+ throw new MetaBindParsingError(`'${inputFieldType}' is not allowed as inline code block`);
`106`	`106`	`}`
`107`	`107`	`}`
`108`	`108`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ export class NumberInputField extends AbstractInputField {`
`21`	`21`	`if (value != null && (typeof value == 'number' \|\| typeof value == 'string')) {`
`22`	`22`	`this.numberComponent.setValue(numberToString(value));`
`23`	`23`	`} else {`
`24`		- console.warn(new MetaBindBindValueError(`invalid value \'${value}\' at numberInputField ${this.inputFieldMarkdownRenderChild.uid}`));
	`24`	+ console.warn(new MetaBindBindValueError(`invalid value '${value}' at numberInputField ${this.inputFieldMarkdownRenderChild.uid}`));
`25`	`25`	`this.numberComponent.setValue(this.getDefaultValue());`
`26`	`26`	`}`
`27`	`27`	`}`