more tests

Author: mProjectsCode

src/utils/Literal.ts

@@ -69,7 +69,7 @@ export function isLiteral(literal: unknown): literal is MBLiteral {
  * @param literal
  */
 export function parseUnknownToLiteralArray(literal: unknown): MBLiteral[] | undefined {
-	if (literal === undefined || literal === null) {
+	if (literal === undefined) {
 		return undefined;
 	}
 
@@ -109,7 +109,7 @@ export function parseUnknownToFloat(literal: unknown): number | undefined {
  */
 export function parseUnknownToInt(literal: unknown): number | undefined {
 	if (typeof literal === 'number') {
-		return literal;
+		return Number.isInteger(literal) ? literal : undefined;
 	} else if (typeof literal === 'string') {
 		const v = intParser.tryParse(literal);
 		if (v.success) {
@@ -126,7 +126,7 @@ export function parseUnknownToInt(literal: unknown): number | undefined {
  * @param literal
  */
 export function parseUnknownToString(literal: unknown): string | undefined {
-	return isLiteral(literal) ? literal?.toString() : undefined;
+	return isLiteral(literal) ? stringifyLiteral(literal) : undefined;
 }
 
 /**
@@ -146,14 +146,26 @@ export function parseUnknownToLiteral(literal: unknown): MBLiteral | undefined {
  */
 export function stringifyUnknown(literal: unknown, nullAsEmpty: boolean): string {
 	if (Array.isArray(literal)) {
-		return literal.map(x => recStringifyUnknown(x, nullAsEmpty)).join(', ');
+		return literal
+			.map(x => recStringifyUnknown(x, nullAsEmpty))
+			.filter(x => x !== '')
+			.join(', ');
 	}
 	return recStringifyUnknown(literal, nullAsEmpty);
 }
 
 function recStringifyUnknown(literal: unknown, nullAsEmpty: boolean): string {
-	if (typeof literal === 'object') {
+	if (literal === null || literal === undefined) {
+		return nullAsEmpty ? '' : 'null';
+	}
+	if (typeof literal === 'function') {
+		return '<function>';
+	}
+
+	if (typeof literal === 'object' || Array.isArray(literal)) {
 		return JSON.stringify(literal);
 	}
-	return literal?.toString() ?? (nullAsEmpty ? '' : 'null');
+
+	// eslint-disable-next-line @typescript-eslint/no-base-to-string
+	return literal.toString();
 }

src/utils/Utils.ts

@@ -98,15 +98,23 @@ export function traverseObjectToParentByPath(
 	pathParts: string[],
 	o: unknown,
 ): { parent: KeyValuePair<string[], unknown>; child: KeyValuePair<string, unknown> } {
-	if (pathParts[0] === '') {
+	if (pathParts.length === 0) {
 		throw new Error('can not traverse to parent on self reference');
 	}
 
 	const parentPath = pathParts.slice(0, -1);
-	const childKey: string = pathParts.at(-1) ?? '';
+	const childKey: string = pathParts.at(-1)!;
 	// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 	const parentObject = traverseObjectByPath(parentPath, o);
 
+	if (parentObject == null) {
+		throw new Error('can not traverse to parent, parent does not exist');
+	}
+
+	if (!(typeof parentObject === 'object')) {
+		throw new Error('can not traverse to parent, parent is not an object');
+	}
+
 	return {
 		parent: { key: parentPath, value: parentObject },
 		// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access

tests/metadataManagerTests/MetadataManager.test.ts

@@ -14,7 +14,7 @@ function subscribe(
 ): { subscription: MetadataSubscription; signal: Signal<unknown>; spy: Mock<ListenerCallback<unknown>> } {
 	const signal = new Signal<unknown>(undefined);
 	const spy = spyOn(signal, 'set');
-	const subscription = manager.subscribe(getUUID(), signal, bindTarget);
+	const subscription = manager.subscribe(getUUID(), signal, bindTarget, () => {});
 	return {
 		subscription: subscription,
 		signal: signal,