fix #348

Author: mProjectsCode

exampleVault/Buttons/Button Example.md

@@ -10,6 +10,12 @@ Meta Bind is getting Buttons
 text `BUTTON[docs-button]` text
 text `BUTTON[docs-button, docs, open-button]` text
 
+```meta-bind
+BUTTON[docs-button]
+```
+
+asase
+
 ```meta-bind-button
 style: primary
 label: Open Meta Bind FAQ

exampleVault/Input Fields/List.md

@@ -18,7 +18,7 @@ list4:
 list5:
   - "[[Other/Example Notes/Example Note with Embeds.md|Example Note with Embeds]]"
   - "[[Other/Example Notes/Example Note with Callouts.md|Example Note with Callouts]]"
-list6: null
+list6: 
 ---
 
 ### List

packages/core/src/fields/button/ButtonField.ts

@@ -12,6 +12,7 @@ export class ButtonField extends Mountable {
 	inline: boolean;
 	position: NotePosition | undefined;
 	buttonComponent?: ButtonComponent;
+	isInGroup: boolean;
 	isPreview: boolean;
 
 	constructor(
@@ -20,6 +21,7 @@ export class ButtonField extends Mountable {
 		filePath: string,
 		renderChildType: RenderChildType,
 		position: NotePosition | undefined,
+		isInGroup: boolean,
 		isPreview: boolean,
 	) {
 		super();
@@ -29,6 +31,7 @@ export class ButtonField extends Mountable {
 		this.filePath = filePath;
 		this.inline = renderChildType === RenderChildType.INLINE;
 		this.position = position;
+		this.isInGroup = isInGroup;
 		this.isPreview = isPreview;
 	}
 
@@ -37,7 +40,7 @@ export class ButtonField extends Mountable {
 		DomHelpers.removeAllClasses(targetEl);
 		DomHelpers.addClasses(targetEl, ['mb-button', this.inline ? 'mb-button-inline' : 'mb-button-block']);
 
-		if (!this.inline && !this.isPreview) {
+		if (!this.inline && !this.isPreview && !this.isInGroup) {
 			if (this.config.id) {
 				this.plugin.api.buttonManager.addButton(this.filePath, this.config);
 			}

packages/core/src/fields/button/ButtonGroupField.ts

@@ -59,20 +59,22 @@ export class ButtonGroupField extends Mountable {
 		for (const buttonId of this.referencedIds) {
 			const wrapperEl = DomHelpers.createElement(targetEl, 'span');
 
-			const initialButton: ButtonComponent | undefined = this.renderInitialButton(wrapperEl, buttonId);
+			let initialButton: ButtonComponent | undefined = this.renderInitialButton(wrapperEl, buttonId);
 			let button: ButtonField | undefined;
 
 			const loadListenerCleanup = this.plugin.api.buttonManager.registerButtonLoadListener(
 				this.filePath,
 				buttonId,
 				(buttonConfig: ButtonConfig) => {
 					initialButton?.$destroy();
+					initialButton = undefined;
 					button = new ButtonField(
 						this.plugin,
 						buttonConfig,
 						this.filePath,
 						this.renderChildType,
 						this.notePosition,
+						true,
 						false,
 					);
 					button.mount(wrapperEl);
@@ -81,6 +83,7 @@ export class ButtonGroupField extends Mountable {
 
 			this.registerUnmountCb(() => {
 				initialButton?.$destroy();
+				initialButton = undefined;
 				button?.unmount();
 				loadListenerCleanup();
 			});

packages/core/src/fields/button/ButtonMountable.ts

@@ -55,6 +55,7 @@ export class ButtonMountable extends FieldMountable {
 			this.getFilePath(),
 			RenderChildType.BLOCK,
 			this.position,
+			false,
 			this.isPreview,
 		);
 		this.buttonField.mount(targetEl);

packages/core/src/modals/modalContents/buttonBuilder/ButtonBuilderModalComponent.svelte

@@ -45,7 +45,7 @@
 		buttonMountable?.unmount();
 		if (el) {
 			DomHelpers.empty(el);
-			buttonMountable = new ButtonField(plugin, config, '', RenderChildType.BLOCK, undefined, true);
+			buttonMountable = new ButtonField(plugin, config, '', RenderChildType.BLOCK, undefined, false, true);
 			buttonMountable.mount(el);
 		}
 	}