generated from obsidianmd/obsidian-sample-plugin
-
-
Notifications
You must be signed in to change notification settings - Fork 71
Closed
Labels
bugUndesired behavior caused by this pluginUndesired behavior caused by this plugin
Description
Please fill out these Check-boxes
- I checked for existing similar issues
- I checked that the plugin is up to date
- The issue persists with all other plugins and themes disabled
Plugin Version
1.2.5
This Issue Occurs on
- Windows
- Linux
- macOS
- Android
- iOS
Debug Info
SYSTEM INFO:
Obsidian version: v1.7.7
Installer version: v1.7.7
Operating system: Windows 10 Enterprise 10.0.19045
Login status: not logged in
Language: en
Insider build toggle: off
Live preview: on
Base theme: adapt to system
Community theme: none
Snippets enabled: 1
Restricted mode: off
Plugins installed: 2
Plugins enabled: 2
1: Meta Bind v1.2.5
2: JS Engine v0.1.20
RECOMMENDATIONS:
Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.
Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.
Describe the Issue
Using the addLabels porpertie on a progressBar input has no effect.
Steps to Reproduce
```meta-bind
INPUT[progressBar(addLabels(true))]
```
```meta-bind
INPUT[progressBar(addLabels(false))]
```
Both produce the exact same result.
Expected Behavior
As documentded, using addLabels(false) should hide the labels.
Additional Info
The option is loaded into the swelt-component same as in the slider, it's just never used:
Line 9 in 09d6371
| addLabels: boolean; |
I am happy to provide a PR for this, I am just not sure if all three labels should be hidden or just the left and right one (leaving the current value displayed)
Lines 130 to 132 in 09d6371
| <span class="mb-progress-bar-value">{value}</span> | |
| <span class="mb-progress-bar-label-left">{props.minValue}</span> | |
| <span class="mb-progress-bar-label-right">{props.maxValue}</span> |
obsidian-meta-bind-plugin/packages/core/src/fields/inputFields/fields/Slider/SliderComponent.svelte
Lines 31 to 33 in 09d6371
| {#if props.addLabels} | |
| <span class="mb-slider-input-label">{props.maxValue}</span> | |
| {/if} |
Metadata
Metadata
Assignees
Labels
bugUndesired behavior caused by this pluginUndesired behavior caused by this plugin