Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 18, 2025

  • Add Rust availability check in setup.py
  • Set explicit paths for rustc and cargo when found
  • Provide helpful error message if Rust is not available
  • Support CARGO and RUSTC environment variables
  • Validate environment variable paths
  • Fix empty string handling for environment variables
  • Add security check to validate rustc binary
  • Improve error handling with better exception catching
  • Test the changes to ensure they work correctly
  • Address code review feedback
  • Fix code formatting to pass CI checks

Summary

Successfully updated setup.py to detect and validate Rust toolchain availability with helpful error messages. Fixed code formatting issues to pass ruff format checks.

Original prompt

can we update setup.py to set the path for rust and fail with a helpful message if rust isn't available?


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copilot AI changed the title [WIP] Update setup.py to set Rust path and check availability Add Rust toolchain detection and helpful error messaging to setup.py Oct 18, 2025
Copilot AI requested a review from joocer October 18, 2025 13:27
Copilot finished work on behalf of joocer October 18, 2025 13:27
@github-actions
Copy link

📦 Opteryx build version: 0.26.0-beta.1666

@joocer
Copy link
Contributor

joocer commented Oct 20, 2025

@copilot these checks fail

Copy link
Contributor Author

Copilot AI commented Oct 20, 2025

@copilot these checks fail

Fixed the code formatting issues with commit 5bc88ff. The setup.py file now passes ruff format checks and all functionality has been verified to work correctly.

Copilot finished work on behalf of joocer October 20, 2025 22:30
@sonarqubecloud
Copy link

@github-actions
Copy link

📦 Opteryx build version: 0.26.0-beta.1666

1 similar comment
@github-actions
Copy link

📦 Opteryx build version: 0.26.0-beta.1666

@joocer joocer closed this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants