Skip to content

Commit 7563e13

Browse files
committed
Merge branch 'main'
2 parents 6c725dd + 0e4ec17 commit 7563e13

File tree

5 files changed

+26
-75
lines changed

5 files changed

+26
-75
lines changed

.github/workflows/release.yml

Lines changed: 21 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
asset_name: rswift-${{ github.event.release.tag_name }}-source.tar.gz
3434
asset_content_type: application/tar+gzip
3535

36-
- name: Build fat binary
36+
- name: Build universal binary
3737
run: |
3838
swift build -c release --arch x86_64 --arch arm64
3939
@@ -43,11 +43,13 @@ jobs:
4343
- name: Import Signing Certificates
4444
uses: apple-actions/import-codesign-certs@v1
4545
with:
46-
p12-file-base64: ${{ secrets.APPLE_CERTS }}
47-
p12-password: ${{ secrets.APPLE_CERTS_PASSWORD }}
46+
p12-file-base64: ${{ secrets.APPLE_CERTIFICATES }}
47+
p12-password: ${{ secrets.APPLE_CERTIFICATES_PASSWORD }}
4848
- name: Code Sign
4949
run: |
50-
codesign --force --options runtime --sign 'Developer ID Application: Mathijs Kadijk (5Z49PA849J)' .build/apple/Products/Release/rswift
50+
codesign --force --options runtime --sign "$IDENTITY" .build/apple/Products/Release/rswift
51+
env:
52+
IDENTITY: 'Developer ID Application: Nonstrict B.V. (WT5N9FK54M)'
5153
- name: Store build artifact
5254
uses: actions/upload-artifact@v3
5355
with:
@@ -60,12 +62,12 @@ jobs:
6062
FILENAME: ${{ runner.temp }}/rswift-${{ github.event.release.tag_name }}.zip
6163
- name: Notarize ZIP
6264
run: |
63-
sh notarize.sh
65+
xcrun notarytool submit $FILENAME --apple-id $APPLE_ID --password $APP_PASSWORD --team-id $TEAM_ID --wait
6466
env:
65-
BUNDLE_ID: nl.mathijskadijk.rswift
66-
DEV_ACCOUNT: ${{ secrets.APPLE_ID_EMAIL }}
67-
PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
68-
DEV_TEAM: 5Z49PA849J
67+
BUNDLE_ID: com.nonstrict.rswift
68+
APPLE_ID: ${{ secrets.APPLE_IDENTIFIER }}
69+
APP_PASSWORD: ${{ secrets.APPLE_IDENTIFIER_PASSWORD }}
70+
TEAM_ID: WT5N9FK54M
6971
FILENAME: ${{ runner.temp }}/rswift-${{ github.event.release.tag_name }}.zip
7072
- name: Attach ZIP to release
7173
uses: actions/upload-release-asset@v1
@@ -89,21 +91,23 @@ jobs:
8991
run: |
9092
mkdir -p $PKG_ROOT/$BINARY_ROOT
9193
cp .build/apple/Products/Release/rswift $PKG_ROOT/$BINARY_ROOT
92-
pkgbuild --root $PKG_ROOT --identifier "nl.mathijskadijk.rswift" --version $TAG_NAME --install-location "/" --sign "Developer ID Installer: Mathijs Kadijk (5Z49PA849J)" $FILENAME
94+
pkgbuild --root $PKG_ROOT --identifier $BUNDLE_ID --version $TAG_NAME --install-location "/" --sign "$IDENTITY" $FILENAME
9395
env:
9496
TAG_NAME: ${{ github.event.release.tag_name }}
9597
FILENAME: ${{ runner.temp }}/rswift-${{ github.event.release.tag_name }}.pkg
96-
BUNDLE_ID: nl.mathijskadijk.rswift
98+
BUNDLE_ID: com.nonstrict.rswift
99+
IDENTITY: 'Developer ID Installer: Nonstrict B.V. (WT5N9FK54M)'
97100
PKG_ROOT: ${{ runner.temp }}/pkgroot
98101
BINARY_ROOT: /usr/local/bin
99102
- name: Notarize PKG
100103
run: |
101-
sh notarize.sh && xcrun stapler staple "$FILENAME"
104+
xcrun notarytool submit $FILENAME --apple-id $APPLE_ID --password $APP_PASSWORD --team-id $TEAM_ID --wait
105+
xcrun stapler staple $FILENAME
102106
env:
103-
BUNDLE_ID: nl.mathijskadijk.rswift
104-
DEV_ACCOUNT: ${{ secrets.APPLE_ID_EMAIL }}
105-
PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
106-
DEV_TEAM: 5Z49PA849J
107+
BUNDLE_ID: com.nonstrict.rswift
108+
APPLE_ID: ${{ secrets.APPLE_IDENTIFIER }}
109+
APP_PASSWORD: ${{ secrets.APPLE_IDENTIFIER_PASSWORD }}
110+
TEAM_ID: WT5N9FK54M
107111
FILENAME: ${{ runner.temp }}/rswift-${{ github.event.release.tag_name }}.pkg
108112
- name: Attach PKG to release
109113
uses: actions/upload-release-asset@v1
@@ -117,3 +121,4 @@ jobs:
117121

118122
- name: Publish to Homebrew
119123
run: brew bump-formula-pr --tag $TAG_NAME --revision $REVISION rswift || exit 0
124+

Documentation/Contribute.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ Thank you for taking some of your precious time helping this project move forwar
88

99
Most important is to read the docs and scan the issue tracker before so you're sure your question/idea/bugreport isn't already answered/in the make/being fixed:
1010

11-
- [Read the Readme](https://github.com/mac-cain13/R.swift/blob/master/Readme.md)
12-
- [Read the other documentation](https://github.com/mac-cain13/R.swift/tree/master/Documentation)
11+
- [Read the Readme](/README.md)
12+
- [Read the other documentation](/Documentation)
1313
- [Check open pull requests](https://github.com/mac-cain13/R.swift/pulls)
1414
- [Search the issue tracker](https://github.com/mac-cain13/R.swift/issues)
1515

Documentation/Ignoring.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ It is also possible to call the binary with the `--rswiftignore` flag and give a
4040

4141

4242
## Only run specific generators (exclude R.something)
43-
By default, R.swift runs all generators, for images, nibs, strings and many more. In some situations you may not want to generate R structs for all these types. You can choose to run only certain generators by adding a flag like this: `--generators image,string` to the call to the [Build Phase](https://github.com/mac-cain13/R.swift/blob/master/Documentation/Images/BuildPhaseExample.png)
43+
By default, R.swift runs all generators, for images, nibs, strings and many more. In some situations you may not want to generate R structs for all these types. You can choose to run only certain generators by adding a flag like this: `--generators image,string` to the call to the [Build Phase](/Documentation/Images/BuildPhaseExample.png)
4444

4545
These are the available generators:
4646

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# R.swift [![Version](https://img.shields.io/cocoapods/v/R.swift.svg?style=flat)](https://cocoapods.org/pods/R.swift) [![License](https://img.shields.io/cocoapods/l/R.swift.svg?style=flat)](blob/master/License) ![Platform](https://img.shields.io/cocoapods/p/R.swift.svg?style=flat)
1+
# R.swift [![Version](https://img.shields.io/cocoapods/v/R.swift.svg?style=flat)](https://cocoapods.org/pods/R.swift) [![License](https://img.shields.io/cocoapods/l/R.swift.svg?style=flat)](License) ![Platform](https://img.shields.io/cocoapods/p/R.swift.svg?style=flat)
22

33
_Get strong typed, autocompleted resources like images, fonts and segues in Swift projects_
44

@@ -81,7 +81,7 @@ Runtime validation with [`R.validate()`](Documentation/Examples.md#runtime-valid
8181
- [Can I use R.swift in a library?](Documentation/QandA.md#can-i-use-rswift-in-a-library)
8282
- [How does R.swift work?](Documentation/QandA.md#how-does-rswift-work)
8383
- [How to upgrade to a new major version?](Documentation/Migration.md)
84-
- [How can I only run specific generators?](https://github.com/mac-cain13/R.swift/blob/master/Documentation/Ignoring.md#only-run-specific-generators-exclude-rsomething)
84+
- [How can I only run specific generators?](Documentation/Ignoring.md#only-run-specific-generators-exclude-rsomething)
8585

8686
## Installation
8787

notarize.sh

Lines changed: 0 additions & 54 deletions
This file was deleted.

0 commit comments

Comments
 (0)