Support nameof keyword

[maca88]

The following example:

public class TestCase
{
  [DefaultValue(nameof(Write))]
  public void Write()
  {
    SimpleFile.Write(nameof(DoSomething));
  }

  private void DoSomething()
  {
  }
}

when transfromed into a new type should generate:

public class TestCaseAsync
{
  [DefaultValue(nameof(WriteAsync))]
  public Task WriteAsync()
  {
    return SimpleFile.WriteAsync(nameof(DoSomething));
  }

  private void DoSomething()
  {
  }
}

where nameof(Write) should be converted to nameof(WriteAsync) and DoSomething must be copied as it is referenced by the argument of WriteAsync method

[fredericDelaporte]

where nameof(Write) should be converted to nameof(WriteAsync)

Is there a test for this? It does not look to work, at least not with v0.8.1 and nameof used in function body, as in:

public class TestCase
{
  public void Write()
  {
    SimpleFile.Write(nameof(Write));
  }
}

When converted as new type, it generates:

public class TestCaseAsync
{
  public Task WriteAsync()
  {
    return SimpleFile.WriteAsync(nameof(Write));
  }
}

Which then fail compiling. (Actual case is here.)

[maca88]

Is there a test for this?

For now there are only two tests, where one of them is related to a new type.

The generator currently produces a valid code for your Write example, the only problem is that an unneeded try/catch block is added, which will be addressed by this issue.
The reason why you got an invalid code generated, is because the nameof argument is currently not converted, when inside and anonymous method passed as an argument, I opened an issue for this as well.

[fredericDelaporte]

Thanks, but it seems there is something else. The case I have linked does not occur inside an anonymous method, but in a variable initialization at the top of the method. In fact I have come back with this trouble because I had it again somewhere else. At this place "Simple LINQ" was originally nameof("SimpleLinqPerf"), and it was not converted too. (Tested again right now.)

And I have checked again the original case, changing this line to var region = nameof(RetrievedQueryCacheMatchesGloballyStoredOne); does trigger the trouble too. So in both cases, nameof is not inside a lambda.

[maca88]

You are right, none of the two issues above is the one that your are hitting. It turns out that the actual problem lies in the ignoreSearchForMethodReferences setting that was added for the test project. While the setting reduces the generation time for the test project (by 35 seconds on my comupter), it will cause a compilation error if one of the test/theory methods are used whitin a nameof keyword (issue).

I've added an additional logic that will override the setting when one of those methods are found inside a nameof keyword. The fixes will be included in the version 0.8.3 that will be released shortly (waiting for Travis-CI to complete).

[fredericDelaporte]

Ok, thanks again!