Tidy up

Author: macaba

source/NSD/NSD.cs

@@ -101,38 +101,25 @@ public static Spectrum Log(Memory<double> input, double sampleRateHz, double fre
             // This ensures consistency of X-coordinate over various view widths.
             double decadeMin = RoundToDecade(freqMin, RoundingMode.Down);
             double decadeMax = RoundToDecade(freqMax, RoundingMode.Up);
-            double decades = Math.Log10(decadeMax / decadeMin);
-            int desiredNumberOfPoints = (int)(decades * pointsPerDecade) + 1;       // + 1 to get points on the decade grid lines
-
             int decadeMinExponent = (int)Math.Log10(decadeMin);
             int decadeMaxExponent = (int)Math.Log10(decadeMax);
-            List<double> meh = [];
+
+            List<double> frequencyList = [];
             int pointsPerDecadeScaled = pointsPerDecade;
             for (int decadeExponent = decadeMinExponent; decadeExponent < decadeMaxExponent; decadeExponent++)
             {
                 double currentDecadeMin = Math.Pow(10, decadeExponent);
                 double currentDecadeMax = Math.Pow(10, decadeExponent + 1);
                 double multiple = Math.Log(currentDecadeMax) - Math.Log(currentDecadeMin);
                 var decadeFrequencies = Enumerable.Range(0, pointsPerDecadeScaled - 1).Select(i => currentDecadeMin * Math.Exp(i * multiple / (pointsPerDecadeScaled - 1))).ToArray();
-                meh.AddRange(decadeFrequencies);
+                frequencyList.AddRange(decadeFrequencies);
                 pointsPerDecadeScaled = (int)(pointsPerDecadeScaled * pointsPerDecadeScaling);
             }
 
             double g = Math.Log(decadeMax) - Math.Log(decadeMin);
-            //double[] frequencies = Enumerable.Range(0, desiredNumberOfPoints).Select(j => decadeMin * Math.Exp(j * g / (desiredNumberOfPoints - 1))).ToArray();
-            double[] frequencies = meh.ToArray();
+            double[] frequencies = frequencyList.ToArray();
             double[] spectrumResolution = frequencies.Select(freq => freq / firstUsableBinForWindow).ToArray();
             // spectrumResolution contains the 'desired resolutions' for each frequency bin, respecting the rule that we want the first usuable bin for the given window.
-
-            // Maybe we also want to scale the spectrum resolution by integer log values?
-            List<int> scalingValues = new List<int>();
-            for(int i = 0; i < desiredNumberOfPoints; i++)
-            {
-                var scale = (int)Math.Exp(i * (g/4.0) / (desiredNumberOfPoints - 1));
-                scalingValues.Add(scale);
-                //spectrumResolution[i] /= scale;
-            }
-
             int[] spectrumLengths = spectrumResolution.Select(resolution => (int)Math.Round(sampleRateHz / resolution)).ToArray();
 
             // Create a job list of valid points to calculate
@@ -168,7 +155,6 @@ public static Spectrum Log(Memory<double> input, double sampleRateHz, double fre
                                     continueLoop = false;
                                     break;
                                 }
-
                             }
                             else
                             {