add serialEventUSB to USART0_Handler #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamvoss
pushed a commit
that referenced
this pull request
Jul 21, 2017
add serialEventUSB to USART0_Handler
adamvoss
pushed a commit
that referenced
this pull request
Jul 31, 2017
add serialEventUSB to USART0_Handler
|
@morganrallen I see this is the same as arduino/ArduinoCore-sam#38. I am curious, have you also considered adding this against the AVR Core? This is only guess work and inferences, but it appears Arduino trys to keep a consistent interface between the cores when possible and that the AVR core gets the most attention with features/pulls sometimes being ported to the other cores. If I have inferred correctly, a pull against AVR may get your change more attention towards being merged. |
|
I actually hadn't thought about it, I guess it makes sense to have it for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as macchina/macchina.github.io#1