Run mlx-ui as non-root user (#339)

Closes #337

Signed-off-by: Christian Kadner <[email protected]>

Author: ckadner

dashboard/origin-mlx/Dockerfile

@@ -1,5 +1,5 @@
 # base image
-FROM node:14-slim
+FROM node:16-slim
 
 # create app directory
 RUN mkdir -p /workspace
@@ -12,11 +12,27 @@ ENV PORT=3000
 
 # install and cache app dependencies
 COPY . /workspace
+
 RUN npm install --silent --only=prod
 
 # install and build UI backend
 RUN cd server && npm install && npm run build
 
-# start app
+# make sure non-root user can modify workspace folder
+#RUN chgrp -R 0 /workspace && chmod -R g=u /workspace
+RUN chown -R node /workspace
+
+# change user
+USER node
+
+# mark as production build
 ENV NODE_ENV=production
+
+# run build on container startup in order to build in environment variables
+#  - https://create-react-app.dev/docs/adding-custom-environment-variables/
+# TODO: find a better solution, i.e.
+#  - https://www.tutorialworks.com/openshift-deploy-react-app/
+#  - https://javaadpatel.com/building-and-deploying-react-containers/
 CMD ["sh", "-c", "npm run build && node server/dist/server.js build/ $PORT"]
+
+

dashboard/origin-mlx/README.md

@@ -56,7 +56,7 @@ http://localhost:3000/settings
 
 ```Bash
 cd dashboard/origin-mlx
-docker build -t <your docker user-id>/<repo name>:<tag name> -f Dockerfile .
+docker build -t <your docker user-id>/mlx-ui:<tag name> -f Dockerfile .
 docker push <your docker user-id>/<repo name>:<tag name>
 ```