Skip to content

Commit fbb6fdc

Browse files
authored
Task/remove vs from execution (#98)
* Add InitializeLifetimeService() * Improve logging * Remove stopwatch * Add logging and make exeption logging consitent * ignore if we can't report the error * Add IFrameworkLogger instead * Add IFrameworkLogger * Remove Microsoft.VisualStudio.TestPlatform.ObjectModel
1 parent 9781660 commit fbb6fdc

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
using Microsoft.VisualStudio.TestPlatform.ObjectModel.Logging;
1+
using System;
22

33
namespace Machine.VSTestAdapter.Execution
44
{
55
public interface IFrameworkLogger
66
{
7-
void SendMessage(TestMessageLevel level, string message);
7+
void SendErrorMessage(string message, Exception exception);
88
}
99
}

src/Machine.Specifications.Runner.VisualStudio/Execution/TestExecutor.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
using System.Reflection;
77
using Machine.Specifications;
88
using Machine.VSTestAdapter.Helpers;
9-
using Microsoft.VisualStudio.TestPlatform.ObjectModel.Adapter;
10-
using Microsoft.VisualStudio.TestPlatform.ObjectModel.Logging;
119

1210
namespace Machine.VSTestAdapter.Execution
1311
{
@@ -71,7 +69,7 @@ public void RunTestsInAssembly(string pathToAssembly, IEnumerable<VisualStudioTe
7169
try
7270
{
7371
var frameworkLogger = specificationRunListener as IFrameworkLogger;
74-
frameworkLogger?.SendMessage(TestMessageLevel.Error, "Machine Specifications Visual Studio Test Adapter - Error Ending Test Run." + Environment.NewLine + exception);
72+
frameworkLogger?.SendErrorMessage("Machine Specifications Visual Studio Test Adapter - Error Ending Test Run.", exception);
7573
}
7674
catch
7775
{

src/Machine.Specifications.Runner.VisualStudio/Execution/VSProxyAssemblySpecificationRunListener.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,9 +169,9 @@ public void OnRunStart()
169169

170170
#endregion
171171

172-
public void SendMessage(TestMessageLevel level, string message)
172+
public void SendErrorMessage(string message, Exception exception)
173173
{
174-
frameworkHandle?.SendMessage(level, message);
174+
frameworkHandle?.SendMessage(TestMessageLevel.Error, message + Environment.NewLine + exception);
175175
}
176176
}
177177
}

0 commit comments

Comments
 (0)