fix: ensure new rollover units are not marked archived

Author: macite

app/models/unit.rb

@@ -287,6 +287,9 @@ def rollover(teaching_period, start_date, end_date, new_code)
       new_unit.end_date = end_date
     end
 
+    # Clear archived
+    new_unit.archived = false
+
     if self.portfolio_auto_generation_date.present?
       # Update the portfolio auto generation date to be the same day of the week and week number as the old date
       new_unit.portfolio_auto_generation_date = new_unit.date_for_week_and_day(week_number(self.portfolio_auto_generation_date), Date::ABBR_DAYNAMES[self.portfolio_auto_generation_date.wday])

test/models/unit_model_test.rb

@@ -881,6 +881,11 @@ def test_archive_unit
     assert File.exist?(FileHelper.task_submission_identifier_path(:done, task))
     assert File.exist?(File.join(FileHelper.task_submission_identifier_path_with_timestamp(:done, task, '123_45'), 'output.txt'))
 
+    new_tp = FactoryBot.create :teaching_period
+    new_unit = unit.rollover(new_tp, nil, nil, nil)
+
+    assert_not new_unit.archived
+
     unit.destroy!
 
     assert_not File.exist?(td.task_sheet), "New file exists after delete - #{td.task_sheet}"