chore: fix cops for learning outcome csvs

Author: macite

app/models/feedback/feedback_chip.rb

@@ -168,8 +168,8 @@ def self.import_feedback_chips_from_csv(file, context_type, context)
 
       CSV.parse(data,
                 headers: true,
-                header_converters: [->(i) { i.nil? ? '' : i }, :downcase, ->(hdr) { hdr.strip unless hdr.nil? }],
-                converters: [->(body) { body.encode!('UTF-8', 'binary', invalid: :replace, undef: :replace, replace: '') unless body.nil? }]).each do |row|
+                header_converters: [->(i) { i.nil? ? '' : i }, :downcase, ->(hdr) { hdr&.strip }],
+                converters: [->(body) { body&.encode('UTF-8', 'binary', invalid: :replace, undef: :replace, replace: '') }]).each do |row|
         # Make sure we're not looking at the header or an empty line
         next if row[0] =~ /unit_code/
 

app/models/task_definition.rb

@@ -317,8 +317,8 @@ def import_outcomes_from_csv(file)
 
     CSV.parse(data,
               headers: true,
-              header_converters: [->(i) { i.nil? ? '' : i }, :downcase, ->(hdr) { hdr.strip unless hdr.nil? }],
-              converters: [->(body) { body.encode!('UTF-8', 'binary', invalid: :replace, undef: :replace, replace: '') unless body.nil? }]).each do |row|
+              header_converters: [->(i) { i.nil? ? '' : i }, :downcase, ->(hdr) { hdr&.strip }],
+              converters: [->(body) { body&.encode('UTF-8', 'binary', invalid: :replace, undef: :replace, replace: '') }]).each do |row|
       # Make sure we're not looking at the header or an empty line
       next if row[0] =~ /abbreviation/