Merge pull request #6 from mackee/fix/pull-request-not-found

ignore request error on 404 not found

Author: mackee

comparison.go

@@ -55,7 +55,8 @@ func (c ComparisonCommit) PullRequest() (PullRequest, error) {
 	}
 
 	pr = PullRequest{
-		Number: number,
+		Number:  number,
+		Fetched: false,
 	}
 
 	return pr, nil

fetcher.go

@@ -3,6 +3,7 @@ package main
 import (
 	"context"
 	"log"
+	"net/http"
 
 	"github.com/google/go-github/github"
 	"github.com/pkg/errors"
@@ -89,6 +90,7 @@ func (f *fetcher) compare(ctx context.Context) (Comparison, error) {
 	if err != nil {
 		return Comparison{}, errors.Wrap(err, "fail fetching comapre commits")
 	}
+
 	var com Comparison
 	if len(comparison.Files) > 0 {
 		files := make([]ComparisonFile, 0, len(comparison.Files))
@@ -168,14 +170,26 @@ func (f *fetcher) MergedPullRequests(ctx context.Context) (PullRequests, error)
 	for _, pr := range prs {
 		_pr := pr
 		eg.Go(func() error {
-			return f.FetchPullRequest(ctx, _pr)
+			err := f.FetchPullRequest(ctx, _pr)
+			if err == nil {
+				return nil
+			}
+			cause := errors.Cause(err)
+			errResp, ok := cause.(*github.ErrorResponse)
+			if ok && errResp.Response.StatusCode == http.StatusNotFound {
+				return nil
+			}
+			return err
 		})
 	}
 	if err := eg.Wait(); err != nil {
 		return nil, err
 	}
 	freezedPRs := make(PullRequests, 0, len(prs))
 	for _, pr := range prs {
+		if !pr.Fetched {
+			continue
+		}
 		if pr.Base != f.Repo.Head {
 			continue
 		}
@@ -195,6 +209,7 @@ func (f *fetcher) FetchPullRequest(ctx context.Context, pr *PullRequest) error {
 	pr.Base = prr.GetBase().GetRef()
 	pr.Title = prr.GetTitle()
 	pr.Author = prr.GetUser().GetLogin()
+	pr.Fetched = true
 
 	return nil
 }

pullrequest.go

@@ -5,11 +5,12 @@ import (
 )
 
 type PullRequest struct {
-	Number int
-	Title  string
-	Head   string
-	Base   string
-	Author string
+	Number  int
+	Title   string
+	Head    string
+	Base    string
+	Author  string
+	Fetched bool
 }
 
 type PullRequests []PullRequest

template.gen.go

@@ -6,19 +6,19 @@ import (
 	"github.com/jessevdk/go-assets"
 )
 
-var _Assetsf000cb359297bc9533188180f9bc040ef1fdcb3e = "title: '[DEPLOY] {{ .Call \"deploy_title\" }}'\nrepo:\n  owner: mackee\n  repo: release-request\n  base: master\n  head: develop\nlabels:\n  - deploy\ntarget_label: deploy ready\nmarkdown: release.md\ncalls:\n  - name: deploy_timing\n    command: |\n      perl -MTime::Piece -E '\n      my $now = Time::Piece->new;\n      for my $hms (qw/16:30:00 19:45:00 23:45:00/) {\n          next if $now->hms gt $hms;\n          say $now->ymd . \" \" . $hms;\n          last;\n      }'\n  - name: deploy_title\n    command: date +\"%Y-%m-%d %H:%M\"\n  - name: has_assets\n    command: |\n      perl -MJSON -E '\n      my $json = do { local $/; <STDIN> };\n      my $releaser = JSON::decode_json($json);\n      my $files = $releaser->{comparison}->{files};\n      my @assets = grep { $_->{name} =~ m!^_example/.*$! } @$files;\n      @assets > 0 ? exit 0 : exit 1;\n      '\ntoken: \"<your token>\"\n"
 var _Assets9d7da04f478156ce3962423189e531c0785612c3 = "# Release\n\nEstimated time of deploying: {{ .Call \"deploy_timing\" }}\n\n## Merged\n\n{{ range .MergedPullRequests -}}\n- [x] #{{ .Number }} {{ .Title }} by @{{ .Author }}\n{{ end }}\n{{ with .OpenedPullRequests }}\n\n## Pendings\n\n{{ range . -}}\n- [ ] #{{ .Number }} {{ .Title }} by @{{ .Author }}\n{{ end }}\n{{ end -}}\n\n## Tasks\n\n{{ with .CallIf \"has_assets\" -}}\n- [ ] generate assets\n\n```console\n$ go generate\n```\n\n{{ end -}}\n\n- [ ] bump tag\n\n```\n$ git tag v1.x.y\n$ git push origin v1.x.y\n```\n\n- [ ] publish release\n\n```\n$ make releases\n```\n"
+var _Assetsf000cb359297bc9533188180f9bc040ef1fdcb3e = "title: '[DEPLOY] {{ .Call \"deploy_title\" }}'\nrepo:\n  owner: mackee\n  repo: release-request\n  base: master\n  head: develop\nlabels:\n  - deploy\ntarget_label: deploy ready\nmarkdown: release.md\ncalls:\n  - name: deploy_timing\n    command: |\n      perl -MTime::Piece -E '\n      my $now = Time::Piece->new;\n      for my $hms (qw/16:30:00 19:45:00 23:45:00/) {\n          next if $now->hms gt $hms;\n          say $now->ymd . \" \" . $hms;\n          last;\n      }'\n  - name: deploy_title\n    command: date +\"%Y-%m-%d %H:%M\"\n  - name: has_assets\n    command: |\n      perl -MJSON -E '\n      my $json = do { local $/; <STDIN> };\n      my $releaser = JSON::decode_json($json);\n      my $files = $releaser->{comparison}->{files};\n      my @assets = grep { $_->{name} =~ m!^_example/.*$! } @$files;\n      @assets > 0 ? exit 0 : exit 1;\n      '\ntoken: \"<your token>\"\n"
 
 // Assets returns go-assets FileSystem
 var Assets = assets.NewFileSystem(map[string][]string{}, map[string]*assets.File{
 	"config.yml": &assets.File{
 		Path:     "config.yml",
 		FileMode: 0x1a4,
-		Mtime:    time.Unix(1510225411, 1510225411000000000),
+		Mtime:    time.Unix(1510543974, 1510543974000000000),
 		Data:     []byte(_Assetsf000cb359297bc9533188180f9bc040ef1fdcb3e),
 	}, "release.md": &assets.File{
 		Path:     "release.md",
 		FileMode: 0x1a4,
-		Mtime:    time.Unix(1510225411, 1510225411000000000),
+		Mtime:    time.Unix(1510543974, 1510543974000000000),
 		Data:     []byte(_Assets9d7da04f478156ce3962423189e531c0785612c3),
 	}}, "")