Require jsonGroupArray take a query-bindable argument (pointfreeco#34)

stephencelis · web-flow · commit 6a13b809796e · 2025-05-05T10:59:56.000-07:00
* Require `jsonGroupArray` take a query-bindable argument Fixes pointfreeco#33. * wip
diff --git a/Sources/StructuredQueriesCore/SQLite/JSONFunctions.swift b/Sources/StructuredQueriesCore/SQLite/JSONFunctions.swift
@@ -16,7 +16,7 @@ extension QueryExpression {
   }
 }
 
-extension QueryExpression where QueryValue: Codable & Sendable {
+extension QueryExpression where QueryValue: Codable & QueryBindable & Sendable {
   /// A JSON array aggregate of this expression
   ///
   /// Concatenates all of the values in a group.
@@ -92,7 +92,7 @@ extension PrimaryKeyedTableDefinition where QueryValue: Codable & Sendable {
     order: (some QueryExpression)? = Bool?.none,
     filter: (some QueryExpression<Bool>)? = Bool?.none
   ) -> some QueryExpression<[QueryValue].JSONRepresentation> {
-    jsonObject.jsonGroupArray(order: order, filter: filter)
+    AggregateFunction("json_group_array", jsonObject, order: order, filter: filter)
   }
 
   private var jsonObject: some QueryExpression<QueryValue> {

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ extension QueryExpression {`
`16`	`16`	`}`
`17`	`17`	`}`
`18`	`18`
`19`		`-extension QueryExpression where QueryValue: Codable & Sendable {`
	`19`	`+extension QueryExpression where QueryValue: Codable & QueryBindable & Sendable {`
`20`	`20`	`/// A JSON array aggregate of this expression`
`21`	`21`	`///`
`22`	`22`	`/// Concatenates all of the values in a group.`
`@@ -92,7 +92,7 @@ extension PrimaryKeyedTableDefinition where QueryValue: Codable & Sendable {`
`92`	`92`	`order: (some QueryExpression)? = Bool?.none,`
`93`	`93`	`filter: (some QueryExpression<Bool>)? = Bool?.none`
`94`	`94`	`) -> some QueryExpression<[QueryValue].JSONRepresentation> {`
`95`		`- jsonObject.jsonGroupArray(order: order, filter: filter)`
	`95`	`+ AggregateFunction("json_group_array", jsonObject, order: order, filter: filter)`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`private var jsonObject: some QueryExpression<QueryValue> {`