added more specs

Author: mackuba

spec/did_spec.rb

@@ -114,4 +114,125 @@
       did.to_s.should == plc_did
     end
   end
+
+  describe 'account status' do
+    let(:document) { stub(:pds_endpoint => 'https://pds.ruby.space') }
+    let(:did) { subject.new(plc_did) }
+
+    before do
+      did.stubs(:document).returns(document)
+
+      stub_request(:get, 'https://pds.ruby.space/xrpc/com.atproto.sync.getRepoStatus')
+        .with(query: { did: plc_did })
+        .to_return(http_response) if defined?(http_response)
+    end
+
+    context 'when repo is active' do
+      let(:http_response) {
+        { body: { active: true }.to_json, headers: { 'Content-Type' => 'application/json' }}
+      }
+
+      it 'should report active account state' do
+        did.account_status.should == :active
+        did.account_active?.should == true
+        did.account_exists?.should == true
+      end
+    end
+
+    context 'when repo is inactive' do
+      let(:http_response) {
+        { body: { active: false, status: 'takendown' }.to_json, headers: { 'Content-Type' => 'application/json' }}
+      }
+
+      it 'should report an inactive existing account' do
+        did.account_status.should == :takendown
+        did.account_active?.should == false
+        did.account_exists?.should == true
+      end
+    end
+
+    context 'when repo is not found' do
+      let(:http_response) {
+        { status: 400, body: { error: 'RepoNotFound' }.to_json, headers: { 'Content-Type' => 'application/json' }}
+      }
+
+      it 'should return nil status and report the account as missing' do
+        did.account_status.should be_nil
+        did.account_active?.should == false
+        did.account_exists?.should == false
+      end
+    end
+
+    context 'when the document has no pds endpoint' do
+      before do
+        did.stubs(:document).returns(stub(:pds_endpoint => nil))
+      end
+
+      it 'should return nil status and report the account as missing' do
+        did.account_status.should be_nil
+        did.account_active?.should == false
+        did.account_exists?.should == false
+      end
+    end
+
+    context 'when active field is not set' do
+      let(:http_response) {
+        { body: { active: nil, status: 'unknown' }.to_json, headers: { 'Content-Type' => 'application/json' }}
+      }
+
+      it 'should raise APIError' do
+        expect { did.account_status }.to raise_error(DIDKit::APIError)
+        expect { did.account_active? }.to raise_error(DIDKit::APIError)
+        expect { did.account_exists? }.to raise_error(DIDKit::APIError)
+      end
+    end
+
+    context 'when active is false but status is not set' do
+      let(:http_response) {
+        { body: { active: false, status: nil }.to_json, headers: { 'Content-Type' => 'application/json' }}
+      }
+
+      it 'should raise APIError' do
+        expect { did.account_status }.to raise_error(DIDKit::APIError)
+        expect { did.account_active? }.to raise_error(DIDKit::APIError)
+        expect { did.account_exists? }.to raise_error(DIDKit::APIError)
+      end
+    end
+
+    context 'when an error different than RepoNotFound is returned' do
+      let(:http_response) {
+        { status: 400, body: { error: 'UserIsJerry' }.to_json, headers: { 'Content-Type' => 'application/json' }}
+      }
+
+      it 'should raise APIError' do
+        expect { did.account_status }.to raise_error(DIDKit::APIError)
+        expect { did.account_active? }.to raise_error(DIDKit::APIError)
+        expect { did.account_exists? }.to raise_error(DIDKit::APIError)
+      end
+    end
+
+    context 'when the response is not application/json' do
+      let(:http_response) {
+        { status: 400, body: 'error', headers: { 'Content-Type' => 'text/html' }}
+      }
+
+      it 'should raise APIError' do
+        expect { did.account_status }.to raise_error(DIDKit::APIError)
+        expect { did.account_active? }.to raise_error(DIDKit::APIError)
+        expect { did.account_exists? }.to raise_error(DIDKit::APIError)
+      end
+    end
+
+    context 'when the response is not 200 or 400' do
+      let(:http_response) {
+        { status: 500, body: { error: 'RepoNotFound' }.to_json, headers: { 'Content-Type' => 'application/json' }}
+      }
+
+      it 'should raise APIError' do
+        expect { did.account_status }.to raise_error(DIDKit::APIError)
+        expect { did.account_active? }.to raise_error(DIDKit::APIError)
+        expect { did.account_exists? }.to raise_error(DIDKit::APIError)
+      end
+    end
+  end
 end

spec/document_spec.rb

@@ -174,7 +174,7 @@
       end
     end
 
-    describe '#pds_host' do
+    describe '#labeler_host' do
       it 'should return the host part of #atproto_labeler endpoint' do
         doc = subject.new(did, service_json)
         doc.labeler_host.should == 'labels.dholms.xyz'

spec/plc_operation_spec.rb

@@ -208,5 +208,151 @@
         expect { subject.new(json) }.to raise_error(DIDKit::PLCOperation::FormatError)
       end
     end
+
+    context 'when a service entry is missing fields' do
+      let(:json) {
+        base_json.tap { |h|
+          h['operation']['services'] = {
+            "atproto_pds" => {
+              "endpoint" => "https://pds.dholms.xyz"
+            },
+            "atproto_labeler" => {
+              "type" => "AtprotoLabeler",
+              "endpoint" => "https://labeler.example.com"
+            }
+          }
+        }
+      }
+
+      it 'should raise a format error' do
+        expect { subject.new(json) }.to raise_error(DIDKit::PLCOperation::FormatError)
+      end
+    end
+
+    context 'when services are valid' do
+      let(:json) {
+        base_json.tap { |h|
+          h['operation']['services'] = {
+            "atproto_pds" => {
+              "type" => "AtprotoPersonalDataServer",
+              "endpoint" => "https://pds.dholms.xyz"
+            },
+            "atproto_labeler" => {
+              "type" => "AtprotoLabeler",
+              "endpoint" => "https://labeler.example.com"
+            },
+            "custom_service" => {
+              "type" => "OtherService",
+              "endpoint" => "https://custom.example.com"
+            }
+          }
+        }
+      }
+
+      it 'should parse services into ServiceRecords' do
+        op = subject.new(json)
+
+        op.services.length.should == 3
+        op.services.each { |s| s.should be_a(DIDKit::ServiceRecord) }
+
+        pds, labeller, custom = op.services
+
+        pds.type.should == 'AtprotoPersonalDataServer'
+        pds.endpoint.should == 'https://pds.dholms.xyz'
+
+        labeller.type.should == 'AtprotoLabeler'
+        labeller.endpoint.should == 'https://labeler.example.com'
+
+        custom.type.should == 'OtherService'
+        custom.endpoint.should == 'https://custom.example.com'
+      end
+
+      it 'should allow fetching services by key + type' do
+        op = subject.new(json)
+
+        custom = op.get_service('custom_service', 'OtherService')
+        custom.should be_a(DIDKit::ServiceRecord)
+        custom.endpoint.should == 'https://custom.example.com'
+      end
+
+      describe '#pds_endpoint' do
+        it 'should return the endpoint of #atproto_pds' do
+          op = subject.new(json)
+          op.pds_endpoint.should == 'https://pds.dholms.xyz'
+        end
+      end
+
+      describe '#pds_host' do
+        it 'should return the host part of #atproto_pds endpoint' do
+          op = subject.new(json)
+          op.pds_host.should == 'pds.dholms.xyz'
+        end
+      end
+
+      describe '#labeler_endpoint' do
+        it 'should return the endpoint of #atproto_labeler' do
+          op = subject.new(json)
+          op.labeler_endpoint.should == 'https://labeler.example.com'
+        end
+      end
+
+      describe '#labeler_host' do
+        it 'should return the host part of #atproto_labeler endpoint' do
+          op = subject.new(json)
+          op.labeler_host.should == 'labeler.example.com'
+        end
+      end
+
+      it 'should expose the "labeller" aliases for endpoint and host' do
+        op = subject.new(json)
+
+        op.labeller_endpoint.should == 'https://labeler.example.com'
+        op.labeller_host.should == 'labeler.example.com'
+      end
+    end
+
+    context 'when services are valid but the specific ones are missing' do
+      let(:json) {
+        base_json.tap { |h|
+          h['operation']['services'] = {
+            "custom_service" => {
+              "type" => "CustomService",
+              "endpoint" => "https://custom.example.com"
+            }
+          }
+        }
+      }
+
+      it 'should parse service records' do
+        op = subject.new(json)
+        op.services.length.should == 1
+      end
+
+      describe '#get_service' do
+        it 'should return nil' do
+          op = subject.new(json)
+          other = op.get_service('other_service', 'OtherService')
+          other.should be_nil
+        end
+      end
+
+      describe '#pds_endpoint' do
+        it 'should return nil' do
+          op = subject.new(json)
+          op.pds_endpoint.should be_nil
+          op.pds_host.should be_nil
+        end
+      end
+
+      describe '#labeler_endpoint' do
+        it 'should return nil' do
+          op = subject.new(json)
+          op.labeler_endpoint.should be_nil
+          op.labeller_endpoint.should be_nil
+          op.labeler_host.should be_nil
+          op.labeller_host.should be_nil
+        end
+      end
+    end
   end
 end