Skip to content

Commit 278dc11

Browse files
Version 12.2.2 (#382)
When toolbar item is clicked, first pop the route and then call its callback - Fixes #346 (#381) * fix: when a toolbar item is clicked, remove route first and then call its callback - fixes #346 * chore: update version and changelog Co-authored-by: Minas Giannekas <[email protected]>
1 parent dd76d06 commit 278dc11

File tree

4 files changed

+6
-3
lines changed

4 files changed

+6
-3
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
## [1.12.2]
2+
* Fixed a bug where clicking on a overflowed toolbar item with a navigation callback wouldn't work ([#346](https://github.com/GroovinChip/macos_ui/issues/346)).
3+
14
## [1.12.1+1]
25
* Fixed a typo in the December abbreviation displayed in the `MacosDatePicker`.
36

example/pubspec.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ packages:
9797
path: ".."
9898
relative: true
9999
source: path
100-
version: "1.12.1+1"
100+
version: "1.12.2"
101101
matcher:
102102
dependency: transitive
103103
description:

lib/src/layout/toolbar/toolbar_overflow_menu_item.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ class _ToolbarOverflowMenuItemState extends State<ToolbarOverflowMenuItem> {
5454
}
5555

5656
void _handleOnTap() {
57-
widget.onPressed?.call();
5857
Navigator.pop(context);
58+
widget.onPressed?.call();
5959
}
6060

6161
bool get _isHighlighted => _isHovered || widget.isSelected == true;

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: macos_ui
22
description: Flutter widgets and themes implementing the current macOS design language.
3-
version: 1.12.1+1
3+
version: 1.12.2
44
homepage: "https://macosui.dev"
55
repository: "https://github.com/GroovinChip/macos_ui"
66

0 commit comments

Comments
 (0)