Skip to content

Commit 9a59245

Browse files
authored
Version 1.12.1 (#375)
* feat: Sliver toolbar (#368) * feat: `SliverToolBar` * chore(example): address lints * docs(SliverToolbar): update `floating` doc * feat(example): add page for SliverToolbar * chore: dart format * docs(SliverToolBar): slight change to `pinned` docs * docs(SliverToolBar): add section to readme * docs(SliverToolBar): tweak sample * test(SliverAppBar): add initial tests * chore: update version & changelog * chore: pub upgrade * chore: remove unused imports * test: remove ignore lint * fix(SidebarItem): use theme's primary color instead of hardcoded value (#374) * fix(SidebarItem): use theme's primary color instead of hardcoded value Fixes #313 * chore: update version, changelog
1 parent f02face commit 9a59245

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
## [1.12.1]
2+
* Fix SidebarItem's leading icons not respecting the theme's primary color
3+
14
## [1.12.0]
25
✨ New widget: `SliverToolBar`
36

example/pubspec.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ packages:
9797
path: ".."
9898
relative: true
9999
source: path
100-
version: "1.12.0"
100+
version: "1.12.1"
101101
matcher:
102102
dependency: transitive
103103
description:

lib/src/layout/sidebar/sidebar_items.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,8 @@ class SidebarItems extends StatelessWidget {
115115
assert(debugCheckHasMacosTheme(context));
116116
assert(currentIndex < _allItems.length);
117117
final theme = MacosTheme.of(context);
118-
return IconTheme.merge(
119-
data: const IconThemeData(size: 20),
118+
return MacosIconTheme.merge(
119+
data: const MacosIconThemeData(size: 20),
120120
child: _SidebarItemsConfiguration(
121121
selectedColor: selectedColor ?? theme.primaryColor,
122122
unselectedColor: unselectedColor ?? MacosColors.transparent,
@@ -288,7 +288,7 @@ class _SidebarItem extends StatelessWidget {
288288
data: MacosIconThemeData(
289289
color: selected
290290
? MacosColors.white
291-
: MacosColors.controlAccentColor,
291+
: theme.primaryColor,
292292
size: itemSize.iconSize,
293293
),
294294
child: item.leading!,

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: macos_ui
22
description: Flutter widgets and themes implementing the current macOS design language.
3-
version: 1.12.0
3+
version: 1.12.1
44
homepage: "https://macosui.dev"
55
repository: "https://github.com/GroovinChip/macos_ui"
66

0 commit comments

Comments
 (0)