patch 8.0.0207: leaking file descriptor when system() fails

brammool · brammool · commit 23c9e8b3bc86 · 2017-01-20T19:59:54.000+01:00
Problem: Leaking file descriptor when system() cannot find the buffer. (Coverity) Solution: Close the file descriptor. (Dominique Pelle, closes #1398)
diff --git a/src/evalfunc.c b/src/evalfunc.c
@@ -11832,6 +11832,7 @@ get_cmd_output_as_rettv(
 	    if (buf == NULL)
 	    {
 		EMSGN(_(e_nobufnr), argvars[1].vval.v_number);
+		fclose(fd);
 		goto errret;
 	    }
 
diff --git a/src/version.c b/src/version.c
@@ -764,6 +764,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    207,
 /**/
     206,
 /**/

Original file line number	Diff line number	Diff line change
`@@ -11832,6 +11832,7 @@ get_cmd_output_as_rettv(`
`11832`	`11832`	`if (buf == NULL)`
`11833`	`11833`	`{`
`11834`	`11834`	`EMSGN(_(e_nobufnr), argvars[1].vval.v_number);`
	`11835`	`+ fclose(fd);`
`11835`	`11836`	`goto errret;`
`11836`	`11837`	`}`
`11837`	`11838`