Commit 3d73af4
committed
Fix macOS 14 Sonoma non-native full screen background color
Non-native full screen's configured background color (default to black)
stopped working when building using macOS 14 SDK, because the main
CoreText view was now drawing over it in drawRect, due to the new
clipToBounds property defaulting to false in macOS 14 SDK.
We could just fix this issue by setting clipToBounds to
true on the text view, but we would lose the benefits of the new
behavior which allows us to show tall texts (e.g. Tibetan texts or other
characters with composing chars) on the first line and not have it be
clipped at the top. Currently with the unclipped behavior, the character
can be drawn and poke up into the window frame or the notch area.
To properly fix this, just clip the background color fill in drawRect,
and allow texts etc to still draw outside the rect.1 parent 784b26c commit 3d73af4
2 files changed
+21
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
760 | 760 | | |
761 | 761 | | |
762 | 762 | | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
763 | 774 | | |
764 | 775 | | |
765 | 776 | | |
| |||
791 | 802 | | |
792 | 803 | | |
793 | 804 | | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
794 | 809 | | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
795 | 813 | | |
796 | 814 | | |
797 | 815 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
55 | 58 | | |
56 | 59 | | |
57 | 60 | | |
| |||
0 commit comments