Skip to content

Commit 5acff71

Browse files
committed
patch 8.0.0340: not checking return valud of dict_add()
Problem: Not checking return valud of dict_add(). (Coverity) Solution: Handle a failure.
1 parent 46522af commit 5acff71

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

src/buffer.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -888,8 +888,13 @@ init_changedtick(buf_T *buf)
888888
di->di_tv.v_type = VAR_NUMBER;
889889
di->di_tv.v_lock = VAR_FIXED;
890890
di->di_tv.vval.v_number = 0;
891-
dict_add(buf->b_vars, di);
892-
buf->b_changedtick = &di->di_tv.vval.v_number;
891+
if (dict_add(buf->b_vars, di) == OK)
892+
buf->b_changedtick = &di->di_tv.vval.v_number;
893+
else
894+
{
895+
vim_free(di);
896+
buf->b_changedtick = &buf->b_ct_val;
897+
}
893898
}
894899
else
895900
#endif

src/version.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -764,6 +764,8 @@ static char *(features[]) =
764764

765765
static int included_patches[] =
766766
{ /* Add new patch number below this line */
767+
/**/
768+
340,
767769
/**/
768770
339,
769771
/**/

0 commit comments

Comments
 (0)