Skip to content

Commit 5dece18

Browse files
committed
Remove DSA key for Sparkle updates
Sparkle has deprecated signing updates with DSA for a long time. MacVim has also added an EdDSA key for a while now. This means we can remove the DSA key and still be pretty safe and certain that vast majority of MacVim users can still update from old versions of MacVim to the new one, using only the EdDSA key. This makes the update process easier and we don't have to use legacy tools to sign each update with the deprecated DSA key.
1 parent 515274b commit 5dece18

File tree

3 files changed

+0
-24
lines changed

3 files changed

+0
-24
lines changed

src/MacVim/Info.plist

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1309,8 +1309,6 @@
13091309
</array>
13101310
<key>SUFeedURL</key>
13111311
<string>https://raw.githubusercontent.com/macvim-dev/macvim/gh-pages/appcast/latest.xml</string>
1312-
<key>SUPublicDSAKeyFile</key>
1313-
<string>dsa_pub.pem</string>
13141312
<key>SUPublicEDKey</key>
13151313
<string>Pt4zsg/8S3/mxKW7Cmt0cZFw/+2LOuXOYS93evP+Mfc=</string>
13161314
<key>NSAppleEventsUsageDescription</key>

src/MacVim/MacVim.xcodeproj/project.pbxproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@
6666
528DA66A1426D4F9003380F1 /* macvim-askpass in Copy Scripts */ = {isa = PBXBuildFile; fileRef = 528DA6691426D4EB003380F1 /* macvim-askpass */; };
6767
52A364731C4A5789005757EC /* Sparkle.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 52A364721C4A5789005757EC /* Sparkle.framework */; settings = {ATTRIBUTES = (Weak, ); }; };
6868
52A364761C4A57C1005757EC /* Sparkle.framework in Copy Frameworks */ = {isa = PBXBuildFile; fileRef = 52A364721C4A5789005757EC /* Sparkle.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };
69-
52B7ED9B1C4A4D6900AFFF15 /* dsa_pub.pem in Resources */ = {isa = PBXBuildFile; fileRef = 52B7ED9A1C4A4D6900AFFF15 /* dsa_pub.pem */; };
7069
8D11072B0486CEB800E47090 /* InfoPlist.strings in Resources */ = {isa = PBXBuildFile; fileRef = 089C165CFE840E0CC02AAC07 /* InfoPlist.strings */; };
7170
8D11072D0486CEB800E47090 /* main.m in Sources */ = {isa = PBXBuildFile; fileRef = 29B97316FDCFA39411CA2CEA /* main.m */; settings = {ATTRIBUTES = (); }; };
7271
8D11072F0486CEB800E47090 /* Cocoa.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 1058C7A1FEA54F0111CA2CBB /* Cocoa.framework */; };
@@ -959,7 +958,6 @@
959958
isa = PBXResourcesBuildPhase;
960959
buildActionMask = 2147483647;
961960
files = (
962-
52B7ED9B1C4A4D6900AFFF15 /* dsa_pub.pem in Resources */,
963961
8D11072B0486CEB800E47090 /* InfoPlist.strings in Resources */,
964962
1D0E051C0BA5F83800B6049E /* Colors.plist in Resources */,
965963
1DD04DEC0C529C5E006CDC2B /* Credits.rtf in Resources */,

src/MacVim/dsa_pub.pem

Lines changed: 0 additions & 20 deletions
This file was deleted.

0 commit comments

Comments
 (0)